Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: station and maxbattles display due to changes on it #1071

Merged
merged 16 commits into from
Nov 18, 2024

Conversation

ReuschelCGN
Copy link
Contributor

@ReuschelCGN ReuschelCGN commented Nov 13, 2024

PR needs Feedback! -> no merge till its done

  • remove stations, not seen > 6hrs (adjustment with local.json possible)
  • text info from 9pm - 6am in popup
  • move popup, when no boss on stationmarker
  • fix search for dynaboss in the night
  • change/fix popup timings
  • fix showTimer end_time
    etc....

for testing with docker use this 1:1 image from PR#1071:
ghcr.io/reuschelcgn/reactmap:max-battle-fix-docker

@ReuschelCGN
Copy link
Contributor Author

No feedback ... no one testing

Copy link
Collaborator

@Mygod Mygod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing seems fine. Left some comments.

README.md Outdated Show resolved Hide resolved
packages/config/.configref Outdated Show resolved Hide resolved
@Fabio1988
Copy link
Contributor

Thanks for this PR :) Testing since yesterday, without any issues :D

@Mygod Mygod merged commit e71f9c2 into WatWowMap:develop Nov 18, 2024
2 checks passed
Copy link

🎉 This PR is included in version 1.35.1-develop.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@ReuschelCGN ReuschelCGN deleted the max-battle-fix branch November 20, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants