Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: no more search hard limits #970

Merged
merged 2 commits into from
Nov 16, 2024
Merged

Conversation

Mygod
Copy link
Collaborator

@Mygod Mygod commented Feb 29, 2024

Copy link
Collaborator

@TurtIeSocks TurtIeSocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! You're welcome to implement a more efficient algorithm if you'd like (or even a library), but since this PR currently undoes an intentionally implemented behavior for performance, it's a no from me.

@Mygod
Copy link
Collaborator Author

Mygod commented Nov 13, 2024

Tested this as well. Since there is a timeout of 2 seconds, this should generally be fine?

@Mygod Mygod requested a review from TurtIeSocks November 13, 2024 19:11
@TurtIeSocks TurtIeSocks merged commit d4f629b into WatWowMap:develop Nov 16, 2024
2 checks passed
Copy link

🎉 This PR is included in version 1.35.1-develop.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@Mygod Mygod deleted the nohardlimit branch November 16, 2024 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants