fix log spam on death #2045
Open
fix log spam on death #2045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Twisted-Code
approved these changes
Jun 14, 2024
There was a problem hiding this comment.
Looks like we just™ return early, with an empty list, if there's no curio inventory to return (because the player is dead, for instance). Intuitive enough to me, but bear in mind I'm not particularly experienced with Java (I also didn't look at the wider context in which this sits but that shouldn't matter if your methods are named appropriately).
|
Shouldn't you have checked that it compiled before submitting a PR, as part of making sure it would work? |
|
🙃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2038 by making function return a empty list if the curios list is not present