Move installation of include headers into a separate script (NFC) #552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change is not meant to change any functionality, only move some Bash-specific logic out of the `Makefile` into its own script: `install-include-headers.sh`. This reduces the perceived complexity of the `Makefile` but the complexity is still there, tucked away in this script. This script also has the advantage that it can be run separately if needed. This commit comes after a few different attempts at building up `Makefile` lists of headers to copy over along with the various locations they must be copied from. It is certainly possible to do this, but due to how we need to remove some headers from the list, it ends up being easier to just `cp` and then `rm`, which this script retains.
This was referenced Nov 20, 2024
I kind of like the llvm (and now emscripten) convention of adding (edit: meaning Non Functional Change) |
abrown
changed the title
sunfishcode
reviewed
Nov 27, 2024
scripts/install-include-headers.sh
Outdated
| # | ||
| # Usage: SYSROOT_INC=... TARGET_TRIPLE=... ./install-include-headers.sh | ||
|
|
||
| set -e |
There was a problem hiding this comment.
I recommend adding set -euo pipefail to all bash scripts. In particular here, -u will catch the case where someone forgets to set SYSROOT_INC or TARGET_TRIPLE.
Also removes the ability to set `DRY_RUN` due to `set -u`; instead, this allows redefining the commands that remove and copy the headers.
sunfishcode
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is not meant to change any functionality, only move some Bash-specific logic out of the
Makefileinto its own script:install-include-headers.sh. This reduces the perceived complexity of theMakefilebut the complexity is still there, tucked away in this script. This script also has the advantage that it can be run separately if needed.This commit comes after a few different attempts at building up
Makefilelists of headers to copy over along with the various locations they must be copied from. It is certainly possible to do this, but due to how we need to remove some headers from the list, it ends up being easier to justcpand thenrm, which this script retains.