Add Clang builtins for threads targets #494
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abrown
force-pushed
the
builtins-for-threads
branch
from
1e7d0a9
to
bbf2ca7
Compare
|
Would it be possible to add some tests for this? (or is it known why this didn't show up on CI?) |
abrown
force-pushed
the
builtins-for-threads
branch
from
bbf2ca7
to
1723c05
Compare
This change adds the `libclang_rt.builtins-wasm32.a` to the appropriate Clang directory for the threaded variants of the WASI targets (`lib/wasi-threads`, `lib/wasip1-threads`). This fixes #543.
This uses the `__floatditf` function which was reported as an issue in [wasi-libc#543]. Compiling and running this test should prove that the builtins are available in the `wasm32-*-threads` targets as long as the tests use those targets (they do, right?). [wasi-libc#543]: WebAssembly/wasi-libc#543
The `__floatdidf` builtin uses a more conventional type--`double`--which means we don't have to guess at the representation of `tf_float`.
abrown
force-pushed
the
builtins-for-threads
branch
from
86ac025
to
24a7308
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds the
libclang_rt.builtins-wasm32.ato the appropriate Clang directory for the threaded variants of the WASI targets (lib/wasi-threads,lib/wasip1-threads). This fixes WebAssembly/wasi-libc#543.