Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cover pending case in close() #274

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

mjwilson-google
Copy link
Contributor

This is to fix #201

Also remove the redundant "Terminate these steps" as the last step in the list.

Copy link
Contributor

@cwilso cwilso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mjwilson-google mjwilson-google merged commit 2cf7190 into WebAudio:gh-pages Jan 21, 2025
1 check passed
@mjwilson-google mjwilson-google deleted the pending-close branch January 21, 2025 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MIDIPort close() does not cover the "pending" case
2 participants