Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explicit notes about allowing multiple calls to promise functions #277

Merged

Conversation

mjwilson-google
Copy link
Contributor

This is to fix #128

However, I'm a bit conflicted on if it's really necessary to explicitly say this.

@mjwilson-google mjwilson-google requested a review from cwilso January 3, 2025 18:09
Copy link
Contributor

@cwilso cwilso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mjwilson-google mjwilson-google merged commit 171204f into WebAudio:gh-pages Jan 21, 2025
1 check passed
@mjwilson-google mjwilson-google deleted the multiple-open-close branch January 21, 2025 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

spec clarification: allow multiple open() and close() requests, and multiple calls to requestMIDIAccess()
2 participants