Skip to content
This repository has been archived by the owner on Feb 27, 2024. It is now read-only.

Hotfix/383 update todos #949

Merged
merged 6 commits into from
Feb 23, 2022
Merged

Hotfix/383 update todos #949

merged 6 commits into from
Feb 23, 2022

Conversation

johnrobertmcc
Copy link
Contributor

@johnrobertmcc johnrobertmcc commented Feb 23, 2022

Linked to #383

Description

Updates:

  • isLinkActive function
  • Converts ExitPreview to an atomic component
  • Removes old todos

TODOS Left to address:

  • connector.js -> figure out how to combine multiple type defs (i.e., WP and other APIs) and pass as single prop here.
  • processGfFieldValues -> Update may be required with GraphQL Gravity Forms ^0.4.1
  • AlgoliaResults.js and Search.js -> Storybook components needed, unsure how to mock data.

Screenshot

isLinkActive now checks for nested routes:
image

Verification

How will a stakeholder test this?

  1. git checkout hotfix/383-update-todos && npm run dev
  2. Go to 'blogs/nested' and check for styling on navbar
  3. ExitPreview unable to be checked currently, see Preview doesn't work with nested URIs #942

@vercel
Copy link

vercel bot commented Feb 23, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/webdevstudios/nextjs-wordpress-starter/FVLb1hQAJUXxQkoFFyrXufR42EWk
✅ Preview: https://nextjs-wordpress-starter-git-hotfix-383-up-7f218d-webdevstudios.vercel.app

@gregrickaby gregrickaby merged commit ce6f329 into main Feb 23, 2022
@gregrickaby gregrickaby deleted the hotfix/383-update-todos branch February 23, 2022 19:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants