check for configured debugger before start to provide a nicer error message #401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage has no change and project coverage change:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## master #401 +/- ##
==========================================
- Coverage 21.30% 20.95% -0.35%
==========================================
Files 14 14
Lines 1737 1766 +29
Branches 375 382 +7
==========================================
Hits 370 370
- Misses 1322 1351 +29
Partials 45 45
☔ View full report in Codecov by Sentry. |
|
That change is easy to test, so those should be added before pulling, too. |
|
@WebFreak001 Should I rebase - or isn't this likely to get merged? |
|
feel free to merge your own commits as well, I think error message improvements and such are always very useful |
GitMensch
force-pushed
the
check-debugger
branch
from
28634f5 to
d559072
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a side issue to #398 (I'd like to provide a similar PR for that).
As I'm currently only "on the browser" I have neither tested that nor run prettier, but I think the current state is enough for a first review.