Fix: explicit typescript type for asElement function #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 20, 2025
|
@WebReflection Hey Andrea, you are probably busy in more interesting things but will you have time to review this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Typescript types generation fails with
esm/dom/utils.js:8:14 - error TS4118: The type of this node cannot be serialized because its property '__@nodeType@27111' cannot be serialized.The jsdoc comment fix the issue
I also added two commands to check the types and the package.json exports.
Note: publint asserts that the types field in package.json must be the first one. this is why I moved it at the top of each exports section