Stop all properties being removed by default #335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benfrancis
force-pushed
the
fix-invisible
branch
from
de343fa to
bc75684
Compare
This was referenced Apr 10, 2024
tim-hellhake
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes WebThingsIO/gateway#3126 for the Zigbee adapter.
In previous versions of the gateway all properties had a
visiblemember which was set to true by default. The Zigbee adapter currently assumes that all properties have avisiblemember and removes from Thing Descriptions if it doesn't evaluate totrue. The latest version of the gateway never adds avisiblemember to property descriptions.This tweak makes sure that properties are not removed by default, and instead only removed if a
visiblemember is explicitly set tofalse.Invisible properties should eventually be re-factored out altogether, see #334.