Stop all properties being removed by default

WebThingsIO · Apr 19, 2024 · 191eb50 · 191eb50
1 parent d2d2ee2
commit 191eb50
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/zwave-classifier.js b/zwave-classifier.js
@@ -758,6 +758,9 @@ class ZWaveClassifier {
     if (name[0] == '_') {
       property.visible = false;
     }
+    // Invisible properties are no longer exposed in Thing Descriptions so
+    // should eventually be removed entirely.
+    // See https://github.com/WebThingsIO/zwave-adapter/issues/140
     return property;
   }
 

diff --git a/zwave-node.js b/zwave-node.js
@@ -73,8 +73,10 @@ class ZWaveNode extends Device {
     dict.zwClasses = this.zwClasses;
     dict.zwValues = this.zwValues;
 
+    // Remove invisible properties from the Thing Description
+    // See https://github.com/WebThingsIO/zwave-adapter/issues/140
     for (const prop of Object.values(dict.properties)) {
-      if (!prop.visible) {
+      if (prop.hasOwnProperty('visible') && prop.visible === false) {
         delete dict.properties[prop.name];
       }
     }