Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: simplify backup repository creation #2362

Merged
merged 1 commit into from
Nov 27, 2024
Merged

chore: simplify backup repository creation #2362

merged 1 commit into from
Nov 27, 2024

Conversation

nijel
Copy link
Member

@nijel nijel commented Nov 27, 2024

Proposed changes

  • move it to the model
  • simplify condition to check first for existing repository without hitting the database
  • prepare for storing more info on backups

Checklist

  • Lint and unit tests pass locally with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added documentation to describe my feature.
  • I have squashed my commits into logic units.
  • I have described the changes in the commit messages.

Other information

@nijel nijel self-assigned this Nov 27, 2024
- move it to the model
- simplify condition to check first for existing repository without
  hitting the database
- prepare for storing more info on backups
Copy link

codecov bot commented Nov 27, 2024

Codecov Report

Attention: Patch coverage is 8.33333% with 22 lines in your changes missing coverage. Please review.

Project coverage is 80.38%. Comparing base (cb78529) to head (7dc4ea2).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2362      +/-   ##
==========================================
+ Coverage   80.35%   80.38%   +0.03%     
==========================================
  Files          50       50              
  Lines        4423     4421       -2     
  Branches      425      424       -1     
==========================================
  Hits         3554     3554              
  Misses        719      719              
+ Partials      150      148       -2     

@nijel nijel merged commit 0fb98c6 into main Nov 27, 2024
15 of 18 checks passed
@nijel nijel deleted the backup-cleanup branch November 27, 2024 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant