Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrated DPC native and triplet pipeline density estimation functions #31

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

sdentro
Copy link
Collaborator

@sdentro sdentro commented Oct 5, 2024

This is phase 2 of the integration of the triplet pipeline into the main DPC package. This now includes the density estimation code that will work in the triplet pipeline and is setup to seamlessly integrate into the standard code without any changes to pipelines to be done. Therefore, to test this new code, it should just run on any sample/case where the triplet pipeline is not required.

For the triplet pipeline, two output files are now slightly different. It either required changing the DPC package code, or a change to the triplet pipeline. I've opted for the latter. This will require a small change to the code that combines the triplet density output. This is underway and will come in phase 3. But for the sake of completeness, these files are different from the current separate triplet pipeline:

  • [samplename]_[triplet id]_DP_and_cluster_info_0.01.txt -> no longer has chr/pos columns
  • [samplename]_[triplet id]_optimaInfo_0.01.txt -> now has cluster.no column

The last paragraph was more for information only. The changes in these commits should integrate without any adaptation of the regular pipeline required and I'm very happy to take feedback where it doesn't!

@sdentro
Copy link
Collaborator Author

sdentro commented Oct 10, 2024

The second and third commits to this contains what I'm referring to as "phase 3": The code that was previously not yet included in the package.

The final phase 4 will add docs and instructions on how to run the triplet pipeline via the package. Then this would be ready for release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant