Update momo shell with better help features and ability to add packages #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hold off on this one for a sec. I need to resolve a build dependency issue. |
- You can now add a package and have it show up as a context in momo - Functions are now listed with short descriptions - Various bugs dealing with handling contexts are fixed Update pymomo unit tests for compatibility with API. Update syslog and add unit tests Add LDF compiler and add header dependency tracking to xc16 build system Update all logging statements to use the new logging format Finish initial support for system log reading and parsing. - supports generating headers from ldf files during build - supports reading the system log over RPC and displaying it - supports parsing the system log messages using ldf files Finished version 1 of system log code - supports displaying parameters with type information Initial documention Update types to correspond with typedargs types Verified that automatic wrapping of long log data works Update momo tool to be able to clear the system log - also remove old modtool log command since this functionality is now part of momo. Allow syslog to display lists of firmware types - log definitions can now have lists of variable length - can now display complex types like scheduled_task and task structures - types now can have a default formatting function Update shared pic24 code for compat with field_service_unit - When no flash is available for persistent logging, just keep everything in the ring buffer. Update documentation to deal with lists of parameters Update doc for firmware types Update system_log documentation Finish initial version of syslog code Update tests and add ringbuffer test code Update pymomo with initial syslog reading implementation Update wording on docs Update unit tests for syslog python component Update automation scripts to run python unit tests Add unit testing for injecting types from external python packages Update momo tool to 0.9 - fix help string printing - refactor shell into HierarchicalShell class in typedargs - allow type injection into momo tool - allow context initialization using rcfile - create RCFile - move firmware_types to shared/pic24 where it belongs Add momo tool documentation Update momo documentation Check and fix windows compatibility Remove debugging statement
|
Alright this should be good to go now. I had to update the log definition file compiler to pull in any special python types that the log might reference and added an option to run momo without using its config file so that builds can be repeatable without any dependence on the machine's environment (i.e. the contents of the momo_config.txt file). |
|
I have a few thoughts about how we could make this even more awesome, but it's pretty awesome as-is! Merging, will open an issue for future enhancements. |
amcgee
added a commit
that referenced
this pull request
Jan 7, 2015
Update momo shell with better help features and ability to add packages
|
Looking forward to it. I love the awesomeness. On 1/7/15 3:58 PM, Austin McGee wrote:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new syslog implementation that does not require sprintf'ing things, allows the logging of typed data and in the future can facilitate hardware testing by allowing the logging of typed data into a special 'test' log that can be inspected to see if hardware tests were successful for or not. The implementation of syslog and usage is detailed here.
The reason why I wanted to change it was so that we can get better data on running momo systems including the actual RAM variables for debugging and development purposes. This required some fairly extensive additional work to automatically match python types with firmware types automatically and is used in syslog as well as read_ram to read controller ram variables and in the future can be used for symbolic debugging in the simulators as well.
The main disadvantage of the new systemlog vs the old one is that you now need a log definition file in order to translate the log messages into english text and match types with the logged parameters. If you don't have a log definition handy for the module, the syslog will do the best it can and always show you as much as it can with the information that it has. There is enough metadata stored with each logged parameter to display it as either an integer, ascii string or binary blob without a log definition but with a log definition file you can give each parameter a name and associate rich types with each binary blob that can have complicated processing and display routines.
Changes from Old System Log
Changes to the MoMo Tool
Additional Changes
Additional work that can be done on these changes (for a future PR) is detailed in Issue #152.