-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: 3d visualizer window is too big. #1969
Conversation
Long error messages were forcing the width of the window to span the entire screen. This was fixed by sending the long message to the log and outputting a short message to the 3d visualizer window.
Thanks! Instead of shortening all the error messages though, would it make sense to maybe just wrap the error message so it doesn't overflow anymore using |
There are two kinds of error that the 3d visualizer may want to convey when the inputs are incorrect. One type is a short message describing what data is wrong, something like, bad indices and colors found. The other which can be potentially huge is a list of all the values that are wrong so that if there are only a few it may help the user find out whats wrong. If we truncate the message then it is not helpful. |
Where are we truncating them? If they get so big they go off-screen at the bottom we should make the error popup scrollable instead |
Yes sorry, I misunderstood what you meant by wrapping. That is indeed a better solution which I'll look into implementing. |
I added the requested code to display the messages with a scroll bar. Please review at your earliest convenience. |
… be accepted by the pattern but produced errors messages during visualization for all other visualizers, so only tested on 3D visualizer.
Thank you! |
Problem description
Long error messages were forcing the width of the window to span the entire screen.
Implementation description
The fix was sending the long message to the log and outputting a short message to the 3d visualizer window.