Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Maple to using property #256

Closed
wants to merge 6 commits into from
Closed

Conversation

summercms
Copy link
Contributor

@summercms summercms commented Apr 14, 2020

As per github issue: #235

Example UA

Mozilla/5.0 (Windows; U; en-US; rv:1.8.1.11; Gecko/20071129; Firefox/2.5.0) Maple 6.0.00077

Before

I get the following results:

Lsxiao\UserAgent\UserAgent Object
(
    [browser] => WhichBrowser\Model\Browser Object
        (
            [using] => 
            [family] => WhichBrowser\Model\Family Object
                (
                    [name] => Firefox
                    [alias] => 
                    [version] => WhichBrowser\Model\Version Object
                        (
                            [value] => 2.5.0
                            [hidden] => 
                            [nickname] => 
                            [alias] => 
                            [details] => 
                            [builds] => 
                        )

                )

            [channel] => 
            [stock] => 
            [hidden] => 
            [mode] => 
            [type] => browser
            [alias] => 
        )

After

Lsxiao\UserAgent\UserAgent Object
(
    [browser] => WhichBrowser\Model\Browser Object
        (
            [using] => WhichBrowser\Model\Using Object
                (
                    [name] => Maple
                    [alias] => 
                    [version] => WhichBrowser\Model\Version Object
                        (
                            [value] => 6.0.00077
                            [hidden] => 
                            [nickname] => 
                            [alias] => 
                            [details] => 
                            [builds] => 
                        )

                )

            [family] => WhichBrowser\Model\Family Object
                (
                    [name] => Firefox
                    [alias] => 
                    [version] => WhichBrowser\Model\Version Object
                        (
                            [value] => 2.5.0
                            [hidden] => 
                            [nickname] => 
                            [alias] => 
                            [details] => 
                            [builds] => 
                        )

                )

            [channel] => 
            [stock] => 
            [hidden] => 
            [mode] => 
            [type] => browser
            [alias] => 
        )

@coveralls
Copy link

coveralls commented Apr 14, 2020

Coverage Status

Coverage remained the same at 100.0% when pulling 7657e74 on ayumi-cloud:Maple into 4899110 on WhichBrowser:master.

@NielsLeenheer
Copy link
Member

I'll check what is going wrong with the rebase. I probably have some time later today.

@summercms summercms closed this Apr 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants