Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make organisation stats retrieval async #337

Merged

Conversation

suecarmol
Copy link
Contributor

Description

  • Changed the stats shown in organisations asynchronous
  • Removed synchronous code in organisations/views.py
  • Removed common templates that are no longer used.

Rationale

Some pages were timing out or taking too long to load. This helps solve this issue.

Phabricator Ticket

T351860

How Has This Been Tested?

Tested manually by loading different organisations and seeing if they time out or not.

Screenshots of your changes (if appropriate):

Types of changes

What types of changes does your code introduce? Add an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@suecarmol suecarmol force-pushed the suecarmol/T351860-ajax-orgs branch from d95b308 to 91a2683 Compare June 5, 2024 19:48
@suecarmol suecarmol marked this pull request as ready for review June 6, 2024 20:00
@suecarmol suecarmol requested review from jsnshrmn and katydidnot June 6, 2024 20:00
@suecarmol suecarmol changed the title Make organisation detail stats retrieval async Make organisation stats retrieval async Jun 6, 2024
@suecarmol suecarmol force-pushed the suecarmol/T351860-ajax-orgs branch from bbcac37 to bb455ff Compare June 7, 2024 01:02
Copy link
Contributor

@katydidnot katydidnot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work on this! It's looking good. Also, was a great opportunity to get familiar with WikiLinks! 🥳

I just had a few questions, some minor nitpicks, and one dev console exception.

Copy link
Member

@jsnshrmn jsnshrmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good and works well in local testing. Thanks!

@jsnshrmn jsnshrmn merged commit 272a86b into WikipediaLibrary:master Jun 10, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants