-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make organisation stats retrieval async #337
Make organisation stats retrieval async #337
Conversation
d95b308
to
91a2683
Compare
It will be loaded only when the Load button is clicked
bbcac37
to
bb455ff
Compare
extlinks/organisations/templates/organisations/organisation_charts_include.html
Outdated
Show resolved
Hide resolved
extlinks/organisations/templates/organisations/organisation_charts_include.html
Outdated
Show resolved
Hide resolved
extlinks/organisations/templates/organisations/organisation_charts_include.html
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your work on this! It's looking good. Also, was a great opportunity to get familiar with WikiLinks! 🥳
I just had a few questions, some minor nitpicks, and one dev console exception.
extlinks/organisations/templates/organisations/organisation_charts_include.html
Outdated
Show resolved
Hide resolved
extlinks/organisations/templates/organisations/organisation_charts_include.html
Show resolved
Hide resolved
extlinks/organisations/templates/organisations/organisation_charts_include.html
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good and works well in local testing. Thanks!
Description
Rationale
Some pages were timing out or taking too long to load. This helps solve this issue.
Phabricator Ticket
T351860
How Has This Been Tested?
Tested manually by loading different organisations and seeing if they time out or not.
Screenshots of your changes (if appropriate):
Types of changes
What types of changes does your code introduce? Add an
x
in all the boxes that apply: