Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annotation create POST api #980

Merged
merged 17 commits into from
Jan 22, 2025
Merged

Annotation create POST api #980

merged 17 commits into from
Jan 22, 2025

Conversation

naknomum
Copy link
Member

@naknomum naknomum commented Jan 10, 2025

POST /api/v3/annotations to create a new Annotation.

PR fixes #920

required (valid) values in payload:

  • mediaAssetId
  • x, y, width, height (theta is optional; will be 0 if not given)
  • iaClass
  • viewpoint
  • encounterId

@codecov-commenter
Copy link

codecov-commenter commented Jan 21, 2025

Codecov Report

Attention: Patch coverage is 0% with 185 lines in your changes missing coverage. Please review.

Project coverage is 0.14%. Comparing base (fbac158) to head (f6cad3b).

Files with missing lines Patch % Lines
src/main/java/org/ecocean/Annotation.java 0.00% 162 Missing ⚠️
src/main/java/org/ecocean/api/BaseObject.java 0.00% 23 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              main    #980      +/-   ##
==========================================
- Coverage     0.14%   0.14%   -0.01%     
  Complexity      29      29              
==========================================
  Files          565     565              
  Lines        63188   63363     +175     
  Branches     10947   10982      +35     
==========================================
  Hits            89      89              
- Misses       63080   63255     +175     
  Partials        19      19              
Flag Coverage Δ
backend 0.14% <0.00%> (-0.01%) ⬇️
frontend 0.14% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@naknomum naknomum marked this pull request as ready for review January 21, 2025 23:42
Copy link
Contributor

@erinz2020 erinz2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@erinz2020 erinz2020 merged commit 00f0af7 into main Jan 22, 2025
1 check passed
@erinz2020 erinz2020 deleted the 920_annotation_create_post branch January 22, 2025 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

POST Create Annotation API
3 participants