Setting up documentation pages #521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpaniaguam
approved these changes
Nov 20, 2024
|
|
||
| ## Cloud masks | ||
| Setting thresholds for cloud mask | ||
|
|
There was a problem hiding this comment.
I guess this is a placeholder. Consider adding a TODO: <my task> which is easy to search for later.
There was a problem hiding this comment.
Yes, this is - there's an item for issue #522 for this
Comment on lines
+81
to
82
| ## NOTE(dmw): For consistency, it would make sense to reverse the order of inputs to match landmask | ||
| function remove_landmask(landmask::BitMatrix, ice_mask::BitMatrix)::Array{Int64} |
There was a problem hiding this comment.
## NOTE(dmw): For consistency, it would make sense to reverse the order of inputs to match landmask
function remove_landmask(landmask::BitMatrix, ice_mask::BitMatrix)::Array{Int64}
Consider adding an issue.
There was a problem hiding this comment.
That's a good idea!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added a placeholder logo and 3 pages where the main families of functions in the algorithm can be described.