Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-11: Add exceptions to backend #12

Merged
merged 8 commits into from
Jun 9, 2024
Merged

GH-11: Add exceptions to backend #12

merged 8 commits into from
Jun 9, 2024

Conversation

ItsNeil17
Copy link
Member

@ItsNeil17 ItsNeil17 commented Jun 9, 2024 •
edited by wos-manager bot
Loading

  • Added BackendException subclassed from BaseException
  • Added AccessForbidden Backend Exception
  • Added ValidationError Backend Exception

None and others added 7 commits May 31, 2024 00:41
Fix: Resolve issues with Player object generation
2b9a4ea 
- Migrate backend to its own directory
- Fix Player generation issues caused by potentially invalid last_npc_win field
- Fix player generation issues caused by unexpected votes field
@Were-Woof
Fix: Make api.get_player() return valid Alliance data
45649f2
@Were-Woof
Fix: Contain player alliance data within Alliance object
d6c2688
@Were-Woof
Fix: Remove unwanted print statement
dbe68a2
@ItsNeil17
Merge branch 'main' into feature/backend
3120d1e 
Signed-off-by: ItsNeil17 <[email protected]>
@ItsNeil17
implement exceptions
707935b 
Signed-off-by: ItsNeil17 <[email protected]>
@ItsNeil17
use implemented exceptions rather than Exception
61a519c 
Signed-off-by: ItsNeil17 <[email protected]>
@ItsNeil17 ItsNeil17 requested a review from Were-Woof June 9, 2024 15:16
@ItsNeil17 ItsNeil17 self-assigned this Jun 9, 2024
@wos-manager wos-manager bot mentioned this pull request Jun 9, 2024
Closed
@ItsNeil17
fix linting
cc35c97 
Signed-off-by: ItsNeil17 <[email protected]>
Were-Woof
Were-Woof approved these changes Jun 9, 2024
View reviewed changes
Copy link
Collaborator

@Were-Woof Were-Woof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ItsNeil17 ItsNeil17 merged commit 97dc025 into main Jun 9, 2024
6 checks passed
@ItsNeil17 ItsNeil17 deleted the feat/backend-exceptions branch June 9, 2024 15:36
@ItsNeil17 ItsNeil17 restored the feat/backend-exceptions branch June 9, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Were-Woof Were-Woof Were-Woof approved these changes

Assignees

@ItsNeil17 ItsNeil17

Labels
type-feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ItsNeil17 @Were-Woof