GH-11: Add exceptions to backend (merge with feature/backend) #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ItsNeil17 <[email protected]>
Signed-off-by: ItsNeil17 <[email protected]>
Signed-off-by: ItsNeil17 <[email protected]>
Signed-off-by: Neil <[email protected]>
|
There's a new commit after the PR has been approved. @RoboItsNeil: please review the changes made to this pull request. |
Signed-off-by: ItsNeil17 <[email protected]>
|
There's a new commit after the PR has been approved. @RoboItsNeil: please review the changes made to this pull request. |
ItsNeil17
added a commit
that referenced
this pull request
Jun 12, 2024
* Fix: Resolve issues with Player object generation - Migrate backend to its own directory - Fix Player generation issues caused by potentially invalid last_npc_win field - Fix player generation issues caused by unexpected votes field * Fix: Make api.get_player() return valid Alliance data * Fix: Contain player alliance data within Alliance object * Fix: Remove unwanted print statement * fix linting * fix linting in models * add __all__ in backend dir * add ruff noqa to init files * GH-11: Add exceptions to backend (merge with feature/backend) (#14) * implement exceptions Signed-off-by: ItsNeil17 <[email protected]> * use implemented exceptions rather than Exception Signed-off-by: ItsNeil17 <[email protected]> * fix linting Signed-off-by: ItsNeil17 <[email protected]> * fix linting Signed-off-by: ItsNeil17 <[email protected]> --------- Signed-off-by: ItsNeil17 <[email protected]> Signed-off-by: Neil <[email protected]> * rename variables and static function from_param to get_instance * feat: Add type hinting to Player.from_data method * chore: Add recruit_troop method to API class * feat: Remove unused fields from MarketOrder model * feat: Add update_alliance_name and update_alliance_user_limit methods to API class * feat: Add get_market_orders method to API class * add pyright static type checker to workflow * remove unnecessary code * update job name * refactor: Rename `path` attribute to `url` in Route class * refactor: Rename `Order` to `MarketOrder` in models/__init__.py * refactor: Update MarketOrder.from_data method to use dictionary input * fix backend pyright * silence gui errors (until they are fixed) * silence gui errors (until they are fixed) * Update lint.yml Signed-off-by: Neil <[email protected]> --------- Signed-off-by: ItsNeil17 <[email protected]> Signed-off-by: Neil <[email protected]> Co-authored-by: None <None> Co-authored-by: Were_Woof <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BackendExceptionsubclassed fromBaseExceptionAccessForbiddenBackend ExceptionValidationErrorBackend Exception