readBytes fix-read-endless-loop

[yufewell]

fix readBytes endless loop

[peter279k]

@yufewell, could you have any test to prove this change?

[yufewell]

@yufewell, could you have any test to prove this change?

yes, cut off wi-fi then readBytes will be endless loop,
i find that the stream's timed_out become true,
hope it helpful.

[Taluu]

Not sure why we would break out of a loop to stop reading but okay. The reading mechanism is flawed anyways...

[yufewell]

Not sure why we would break out of a loop to stop reading but okay. The reading mechanism is flawed anyways...
this is only happen while network is nearly turned off.
when network is terrible, fread alwarys return empty string, so the stream will become timed out, then the loop will last forever.
in my case, i need break to reconnect to server...

[yufewell]

Not sure why we would break out of a loop to stop reading but okay. The reading mechanism is flawed anyways...

also can use keepAlive function to reconnect...

[Taluu]

To be honest, not sure if I'm truly convinced this patch is needed.

But I can be wrong...

[Taluu]

This seems pretty arbitrary that after 2 iterations, we would make it die.

[yufewell]

i did not find correct way to solve endless loop problem.
when fread always return empty string, cpu will went high and loop will not break off.
i tried some ways, timed_out, is_resource... but did not work...

[Taluu]

What could be done would be to temper with pcntl signals to stop the loop then. WDYT ?

[guillaumepotier]

To be honest, not sure if I'm truly convinced this patch is needed.
But I can be wrong...

You, wrong ? Nah !!!!