Adding Environment Variable Credential Support #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request resolves issue #12 by allowing the user to utilize AWS credentials in environment variables. this is done by injecting the following environment variables into the container when executing commands:
AWS_ACCESS_KEY_IDAWS_SECRET_ACCESS_KEYAWS_SESSION_TOKENAWS_SECURITY_TOKENThis will allow users to utilize tools such as https://github.com/segmentio/aws-okta to run the application. In order to use this functionality instead of using a profile, I have added the
--envflag to load credentials via environment variable instead of aws profile. When the--envflag is used and a database is not specified, I have it default togeneral.dbfor lack of a better name.I have tested this on several of our accounts with success. If you have any suggested changes please let me know!