Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add external C linkage wrappers for some wwtools functions #11

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from
Draft

feat: add external C linkage wrappers for some wwtools functions #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
96fccef
feat: add external C linkage wrappers for some wwtools functions
abheekda1 Jun 7, 2022
efb5690
fix: dynamically allocate memory for C strings and remove big object …
abheekda1 Jun 7, 2022
56401b7
fix: include correct header for strncpy
abheekda1 Jun 7, 2022
f251d9b
refactor: remove unnecessarily large header
abheekda1 Jun 7, 2022
3fbd14b
fix: temporarily remove usage of overly large header
abheekda1 Jun 7, 2022
4231293
fix: use size instead of terminating '\0' due to binary files
abheekda1 Jun 7, 2022
3143370
fix: fully working wem_to_ogg C exported function
abheekda1 Jun 8, 2022
ed316b9
fix: prevent allocating unnecessary memory and fix DLL exports
abheekda1 Jun 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,10 @@ include_directories(

add_definitions(-DKS_STR_ENCODING_NONE)

if(MSVC)
add_definitions(-D_CRT_SECURE_NO_WARNINGS)
endif()

set(SOURCE
src/ww2ogg/codebook.cpp
src/ww2ogg/crc.c
Expand All @@ -35,6 +39,14 @@ set(SOURCE
src/kaitai/structs/wem.cpp
)

# add compilation support for large objects
# https://stackoverflow.com/questions/69903253/cmake-bigobj-no-such-file-or-directory
# if (MSVC)
# add_compile_options(/bigobj)
# else ()
# add_compile_options(-Wa,-mbig-obj)
# endif ()

add_subdirectory(libogg EXCLUDE_FROM_ALL)
add_subdirectory(libvorbis EXCLUDE_FROM_ALL)

Expand Down
2 changes: 2 additions & 0 deletions include/wwtools/bnk.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,9 @@ std::string get_event_id_info(const std::string &indata,
*/
std::string get_wem_id_at_index(const std::string &indata, const int &index);

/*
std::string get_event_name_from_id(const std::uint32_t &event_id);
*/

/**
* @brief get a string with the action type from the enum
Expand Down
Loading