Skip to content
This repository has been archived by the owner on Apr 5, 2022. It is now read-only.

Update to the last flood version (4.1.2) and optimize start speed #24

Merged
merged 2 commits into from
Nov 23, 2020

Conversation

Coosos
Copy link
Contributor

@Coosos Coosos commented Nov 22, 2020

Update flood to 4.1.2

From flood 4.0.0, config file is modified.

  • "pollInterval" is replaced by "torrentClientPollInterval"
  • "torrentClientPollIntervalIdle" is required parameter because is forced by cli option* (default: '1000 * 60 * 15')
  • "disableUsersAndAuth" is replaced by "authMethod"
  • "floodServerHost" is required parameter because is forced by cli option* (default: '0.0.0.0')
  • The "configUser" object changes to separate the connection type
  • "secret" must contain at least 30 characters (https://github.com/jesec/flood/blob/master/CHANGELOG.md#410-november-17-2020)

Optimize start speed

In rootfs/usr/local/bin/run.sh, is not necessary to change owner for all files in /usr/flood because flood is build in /usr/flood/dist 😄

Now the container starts in 10 seconds 👍 (instead of many minutes 👎)

Note: su-exec is vulnerable (check: ncopa/su-exec#23)

@Wonderfall
Copy link
Owner

Thank you very much.

Note: su-exec is vulnerable

I agree, reducing privileges is vulnerable by design. It's better to use Docker namespaces and even better, Docker rootless (and even better, Podman, but it's still buggy IMO).

For now I intend to keep this image running that way so running as root is avoided at any cost. Reducing privileges is better than nothing at all! Docker security is a bit complex for the average user.

@Wonderfall Wonderfall merged commit 02122e6 into Wonderfall:master Nov 23, 2020
@Coosos Coosos deleted the feature-update-flood branch November 24, 2020 00:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants