Skip to content

Commit

Permalink
2024 Theme: Fix invalid html in header and footer
Browse files Browse the repository at this point in the history
The header and footer template parts by default use header and footer elements, but they include the global header and footer elements, leading to invalid HTML.

Using a div instead fixes this.
  • Loading branch information
adamwoodnz committed May 30, 2024
1 parent 7894932 commit e25b050
Show file tree
Hide file tree
Showing 11 changed files with 21 additions and 21 deletions.
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<!-- wp:template-part {"slug":"header","className":"has-display-contents"} /-->
<!-- wp:template-part {"slug":"header","className":"has-display-contents","tagName":"div"} /-->

<!-- wp:group {"tagName":"main","layout":{"type":"constrained"},"className":"entry-content","style":{"spacing":{"blockGap":"0px"}}} -->
<main class="wp-block-group entry-content">
Expand All @@ -16,4 +16,4 @@
</main>
<!-- /wp:group -->

<!-- wp:template-part {"slug":"footer"} /-->
<!-- wp:template-part {"slug":"footer","tagName":"div"} /-->
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<!-- wp:template-part {"slug":"header","className":"has-display-contents"} /-->
<!-- wp:template-part {"slug":"header","className":"has-display-contents","tagName":"div"} /-->

<!-- wp:group {"tagName":"main","layout":{"type":"constrained"},"className":"entry-content","style":{"spacing":{"blockGap":"0px"}}} -->
<main class="wp-block-group entry-content">
Expand All @@ -16,4 +16,4 @@
</main>
<!-- /wp:group -->

<!-- wp:template-part {"slug":"footer"} /-->
<!-- wp:template-part {"slug":"footer","tagName":"div"} /-->
4 changes: 2 additions & 2 deletions wp-content/themes/pub/wporg-learn-2024/templates/archive.html
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<!-- wp:template-part {"slug":"header","className":"has-display-contents"} /-->
<!-- wp:template-part {"slug":"header","className":"has-display-contents","tagName":"div"} /-->

<!-- wp:group {"tagName":"main","layout":{"type":"constrained"},"className":"entry-content","style":{"spacing":{"blockGap":"0px"}}} -->
<main class="wp-block-group entry-content">
Expand All @@ -16,4 +16,4 @@
</main>
<!-- /wp:group -->

<!-- wp:template-part {"slug":"footer"} /-->
<!-- wp:template-part {"slug":"footer","tagName":"div"} /-->
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,4 @@
</main>
<!-- /wp:group -->

<!-- wp:template-part {"slug":"footer"} /-->
<!-- wp:template-part {"slug":"footer","tagName":"div"} /-->
4 changes: 2 additions & 2 deletions wp-content/themes/pub/wporg-learn-2024/templates/index.html
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
<!-- wp:template-part {"slug":"header","className":"has-display-contents"} /-->
<!-- wp:template-part {"slug":"header","className":"has-display-contents","tagName":"div"} /-->
index
<!-- wp:template-part {"slug":"footer"} /-->
<!-- wp:template-part {"slug":"footer","tagName":"div"} /-->
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<!-- wp:template-part {"slug":"header","className":"has-display-contents"} /-->
<!-- wp:template-part {"slug":"header","className":"has-display-contents","tagName":"div"} /-->

<!-- wp:group {"tagName":"main","layout":{"type":"constrained"},"className":"entry-content","style":{"spacing":{"blockGap":"0px"}}} -->
<main class="wp-block-group entry-content">
Expand All @@ -18,4 +18,4 @@
</main>
<!-- /wp:group -->

<!-- wp:template-part {"slug":"footer"} /-->
<!-- wp:template-part {"slug":"footer","tagName":"div"} /-->
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<!-- wp:template-part {"slug":"header","className":"has-display-contents"} /-->
<!-- wp:template-part {"slug":"header","className":"has-display-contents","tagName":"div"} /-->

<!-- wp:group {"tagName":"main","layout":{"type":"constrained"},"className":"entry-content","style":{"spacing":{"blockGap":"0px"}}} -->
<main class="wp-block-group entry-content">
Expand All @@ -16,4 +16,4 @@
</main>
<!-- /wp:group -->

<!-- wp:template-part {"slug":"footer"} /-->
<!-- wp:template-part {"slug":"footer","tagName":"div"} /-->
4 changes: 2 additions & 2 deletions wp-content/themes/pub/wporg-learn-2024/templates/page.html
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<!-- wp:template-part {"slug":"header","className":"has-display-contents"} /-->
<!-- wp:template-part {"slug":"header","className":"has-display-contents","tagName":"div"} /-->

<!-- wp:group {"tagName":"main","layout":{"type":"constrained"},"className":"entry-content","style":{"spacing":{"blockGap":"0px"}}} -->
<main class="wp-block-group entry-content">
Expand All @@ -16,4 +16,4 @@
</main>
<!-- /wp:group -->

<!-- wp:template-part {"slug":"footer"} /-->
<!-- wp:template-part {"slug":"footer","tagName":"div"} /-->
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<!-- wp:template-part {"slug":"header","className":"has-display-contents"} /-->
<!-- wp:template-part {"slug":"header","className":"has-display-contents","tagName":"div"} /-->

<!-- wp:group {"tagName":"main","layout":{"type":"constrained"},"className":"entry-content","style":{"spacing":{"blockGap":"0px"}}} -->
<main class="wp-block-group entry-content">
Expand All @@ -16,4 +16,4 @@
</main>
<!-- /wp:group -->

<!-- wp:template-part {"slug":"footer"} /-->
<!-- wp:template-part {"slug":"footer","tagName":"div"} /-->
4 changes: 2 additions & 2 deletions wp-content/themes/pub/wporg-learn-2024/templates/single.html
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<!-- wp:template-part {"slug":"header","className":"has-display-contents"} /-->
<!-- wp:template-part {"slug":"header","className":"has-display-contents","tagName":"div"} /-->

<!-- wp:group {"tagName":"main","layout":{"type":"constrained"},"className":"entry-content","style":{"spacing":{"blockGap":"0px"}}} -->
<main class="wp-block-group entry-content">
Expand All @@ -16,4 +16,4 @@
</main>
<!-- /wp:group -->

<!-- wp:template-part {"slug":"footer"} /-->
<!-- wp:template-part {"slug":"footer","tagName":"div"} /-->
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<!-- wp:template-part {"slug":"header","className":"has-display-contents"} /-->
<!-- wp:template-part {"slug":"header","className":"has-display-contents","tagName":"div"} /-->

<!-- wp:group {"tagName":"main","layout":{"type":"constrained"},"className":"entry-content","style":{"spacing":{"blockGap":"0px"}}} -->
<main class="wp-block-group entry-content">
Expand Down Expand Up @@ -42,4 +42,4 @@
</main>
<!-- /wp:group -->

<!-- wp:template-part {"slug":"footer"} /-->
<!-- wp:template-part {"slug":"footer","tagName":"div"} /-->

0 comments on commit e25b050

Please sign in to comment.