Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update content for redesigned Meeting Calendar plugin #2945

Merged
merged 1 commit into from
Oct 14, 2024
Merged

Update content for redesigned Meeting Calendar plugin #2945

merged 1 commit into from
Oct 14, 2024

Conversation

adamwoodnz
Copy link
Contributor

@adamwoodnz adamwoodnz commented Oct 10, 2024 •
edited
Loading

When the Meeting Calendar redesign PR is merged most of the styles we added to the Learn 2024 theme will not be required anymore.

This PR removes all the custom styles, and some content which is now rendered by plugin. Only styles for hiding specific elements not relevant to Learn remain.

See #2944

Changes

  1. The previous and next navigation buttons have changed in the plugin
  2. The team filter is hidden. We were relying on no teams being set, but some more have been added, so the dropdown started to be shown again. I believe these are not useful and are probably data entry mistakes:
  1. 'Events are shown in your local time zone.' has been extracted from the copy at the bottom as this is now rendered by the plugin. Same goes for the feed links.
Before After
Screenshot 2024-10-10 at 9 13 35 PM Screenshot 2024-10-10 at 9 12 37 PM

Testing

Best tested in sandbox.

  1. Load this branch and Redesign calendar frontend meeting-calendar#159
  2. Test calendar view and list view for regressions. Include modal event details for calendar view
  3. Test feed links
  4. Test responsiveness

@adamwoodnz
Update content for redesigned Meeting Calendar plugin
3d6d1d0 
Remove custom styles and content which is now rendered by plugin.
Leave styles for hiding specific elements not relevant to Learn.

See #2944
@adamwoodnz adamwoodnz self-assigned this Oct 10, 2024
@adamwoodnz adamwoodnz added [Component] Meeting Plugin Issues relating to the plugin for Online Workshops: https://github.com/WordPress/meeting-calendar [Component] Learn Theme Website development issues related to the Learn theme. labels Oct 10, 2024
@adamwoodnz adamwoodnz requested a review from renintw October 10, 2024 08:23
@adamwoodnz adamwoodnz mentioned this pull request Oct 10, 2024
Merged
@adamwoodnz adamwoodnz merged commit 18ffa8b into trunk Oct 14, 2024
1 check passed
@adamwoodnz adamwoodnz deleted the update/2944-meeting-calendar-plugin branch October 14, 2024 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renintw renintw Awaiting requested review from renintw

Assignees

@adamwoodnz adamwoodnz

Labels
[Component] Learn Theme Website development issues related to the Learn theme. [Component] Meeting Plugin Issues relating to the plugin for Online Workshops: https://github.com/WordPress/meeting-calendar
Projects
WordPress.org
Status: ✅ Done
Milestone
Learning Pathways Post-launch
Development

Successfully merging this pull request may close these issues.
1 participant
@adamwoodnz