Skip to content

Commit

Permalink
Enable shadow support for cover block
Browse files Browse the repository at this point in the history
On previous attempts to do this, the cover block was displaying
inconsistencies between how it was rendered in the editor vs the
frontend; that doesn't seem to be the case anymore, so we should be
able to enable shadow support without any modifications to the block itself.

I'd still appreciate some eyes on this, because I don't know what
exactly has changed since the first time I attempted this.

Tracking issue: #57103

Co-authored-by: vcanales <[email protected]>
Co-authored-by: madhusudhand <[email protected]>
  • Loading branch information
3 people committed May 25, 2024
1 parent 62b0efd commit 770fa91
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
2 changes: 1 addition & 1 deletion docs/reference-guides/core-blocks.md
Original file line number Diff line number Diff line change
Expand Up @@ -245,7 +245,7 @@ Add an image or video with a text overlay. ([Source](https://github.com/WordPres

- **Name:** core/cover
- **Category:** media
- **Supports:** align, anchor, color (heading, text, ~~background~~, ~~enableContrastChecker~~), dimensions (aspectRatio), interactivity (clientNavigation), layout (~~allowJustification~~), spacing (blockGap, margin, padding), typography (fontSize, lineHeight), ~~html~~
- **Supports:** align, anchor, color (heading, text, ~~background~~, ~~enableContrastChecker~~), dimensions (aspectRatio), interactivity (clientNavigation), layout (~~allowJustification~~), shadow, spacing (blockGap, margin, padding), typography (fontSize, lineHeight), ~~html~~
- **Attributes:** allowedBlocks, alt, backgroundType, contentPosition, customGradient, customOverlayColor, dimRatio, focalPoint, gradient, hasParallax, id, isDark, isRepeated, isUserOverlayColor, minHeight, minHeightUnit, overlayColor, tagName, templateLock, url, useFeaturedImage

## Details
Expand Down
1 change: 1 addition & 0 deletions packages/block-library/src/cover/block.json
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,7 @@
"anchor": true,
"align": true,
"html": false,
"shadow": true,
"spacing": {
"padding": true,
"margin": [ "top", "bottom" ],
Expand Down

0 comments on commit 770fa91

Please sign in to comment.