Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Local autosave: expand e2e test coverage #17495

Closed
mcsf opened this issue Sep 20, 2019 · 3 comments · Fixed by #19915
Closed

Local autosave: expand e2e test coverage #17495

mcsf opened this issue Sep 20, 2019 · 3 comments · Fixed by #19915
Assignees
@mcsf
Labels
[Feature] Saving Related to saving functionality [Priority] High Used to indicate top priority items that need quick attention [Status] In Progress Tracking issues with work in progress

Comments

@mcsf
Copy link
Contributor

mcsf commented Sep 20, 2019 •
edited
Loading

Follow up on #16490. See #16490 (review):

  • Add documentation for the newly introduced component
  • Make the local autosave interval configurable so sites could tweak it and at the same time to speed up e2e tests
  • Let's add more e2e tests which cover other use cases like (mostly to prevent regressions):
    logging out - which wipes the saved post ensuring that the saved content doesn't get loaded in the other post
@mcsf mcsf added the [Priority] High Used to indicate top priority items that need quick attention label Sep 20, 2019
@mcsf mcsf self-assigned this Sep 20, 2019
@mcsf mcsf added the [Feature] Saving Related to saving functionality label Sep 20, 2019
@mcsf mcsf mentioned this issue Sep 20, 2019
Merged
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Sep 20, 2019
@gziolo
Copy link
Member

gziolo commented Nov 12, 2019

Can we consider it done? There were a few follow-up PRs.

@jorgefilipecosta
Copy link
Member

Closing this issue as it seems some end to end tests were already added.

@mcsf
Copy link
Contributor Author

mcsf commented Jan 27, 2020

I never got round to adding documentation, and that's why the issue remained open.

@mcsf mcsf mentioned this issue Jan 27, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mcsf mcsf

Labels
[Feature] Saving Related to saving functionality [Priority] High Used to indicate top priority items that need quick attention [Status] In Progress Tracking issues with work in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add docs for LocalAutosaveMonitor and __experimentalUpdateLocalAutosaveInterval WordPress/gutenberg
3 participants
@mcsf @gziolo @jorgefilipecosta