Local autosave: Expand E2E tests #17503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcsf
requested review from
ajitbohra,
gziolo,
nerrad,
ntwb and
talldan
as code owners
epiqueras
reviewed
Sep 20, 2019
| expect( await page.evaluate( () => window.sessionStorage.length ) ).toBe( 1 ); | ||
|
|
||
| const logoutUrl = await page.$eval( '#wp-admin-bar-logout a', ( element ) => element.href ); | ||
| await page.goto( logoutUrl ); |
There was a problem hiding this comment.
Can't we just click on the button/link?
There was a problem hiding this comment.
Right, click should work better in this case 👍
gziolo
added
the
[Type] Automated Testing
Well spotted. |
epiqueras
approved these changes
Sep 25, 2019
mcsf
force-pushed
the
update/local-autosave-e2e-tests
branch
from
efb00c2 to
482ce6d
Compare
Thanks! |
mcsf
force-pushed
the
update/local-autosave-e2e-tests
branch
from
482ce6d to
eb2eba8
Compare
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes part of #17495