-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shadow: tools panel label is set to Shadow instead of Border & Shadow #60192
Comments
Going to add this to the 6.5.1 section for consideration since this impacts a feature coming to 6.5 but is minor in the grand scheme of things. |
My guess is that it's because we're directly overriding the hook's props here. gutenberg/packages/block-editor/src/hooks/border.js Lines 237 to 242 in 91ea8fa
Update: It seems that the above is not the cause. I'll continue researching, but I'd be happy if anyone can find a solution to this problem. |
As I understand the function useBorderPanelLabel uses But, the settings object is being returned differently from different instances. for comparison
from global styles returns gutenberg/packages/block-editor/src/components/inspector-controls-tabs/styles-tab.js Line 15 in 0f689f9
from block inspector-controls returns I don't understand the reason behind this. |
Yes, I'm also wondering why this happens 🤔 |
Given this, I'm going to remove this issue from the 6.5.x board, since we no longer plan to address it in a minor release. |
This is issue when the support is enabled in classic themes in #60373 |
This is not a regression, must be punted to 6.7 |
Description
When
defaultPresets
is set to true in classic themesvia functions.php
Issue: Label is set to
Shadow
even though there exists radius control.Expectation: When Border and shadow controls both present label should be set to
Border & Shadow
Step-by-step reproduction instructions
Enable defaultPresets by adding following code to
functions.php
Screenshots, screen recording, code snippet
No response
Environment info
Please confirm that you have searched existing issues in the repo.
Yes
Please confirm that you have tested with all plugins deactivated except Gutenberg.
Yes
The text was updated successfully, but these errors were encountered: