-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shadow: revert shadow default presets opt-in to opt-out #60204
Conversation
a37c3ac
to
4e5e5d3
Compare
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for getting the backport to GB opened up.
LGTM 👍
Warning: Type of PR label mismatch To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task. |
This is a backport to Gutenberg for Trac #60815 and the WordPress/wordpress-develop#6309 fix. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes are in line with the changes in WordPress/wordpress-develop#6309, so I think this is good to land.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@oandregal added some tests to the core changeset. @madhusudhand can you copy those over here as well?
4e5e5d3
to
e22b910
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for getting the tests copied over!
What?
This change reverts part of changes from #58766 and #59499.
It is to sync changes from WordPress/wordpress-develop#6309 back to Gutenberg.
Why?
Previous fix causing regression as mentioned here
How?
Restores defaultPresets to
true
and removes it from appearanceTools.Testing Instructions
Block theme:
Classic themes:
Also, test this regression scenario.
Screenshots or screencast
Fixes: #59989