Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make custom HTML blocks resizable #8245

Closed
Pikamander2 opened this issue Jul 27, 2018 · 5 comments · Fixed by #16187
Closed

Make custom HTML blocks resizable #8245

Pikamander2 opened this issue Jul 27, 2018 · 5 comments · Fixed by #16187
Assignees
@nicolad
Labels
[Block] HTML Affects the the HTML Block [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.
Milestone
WordPress 5.x

Comments

@Pikamander2
Copy link

Pikamander2 commented Jul 27, 2018 •
edited
Loading

image

I don't always need to see every line of code in a custom HTML block, especially when I'm editing a completely different element. Sometimes I just want to minimize it or limit it to a certain height.

Please consider adding a stretch handle or minimize button.
@designsimply designsimply added [Type] Enhancement A suggestion for improvement. [Feature] Blocks Overall functionality of blocks labels Jul 27, 2018
@mtias mtias added the Good First Issue An issue that's suitable for someone looking to contribute for the first time label Sep 11, 2018
@mtias
Copy link
Member

mtias commented Sep 11, 2018

We might also consider minimizing by default when the block is not focused.

@mtias mtias added the Needs Design Feedback Needs general design feedback. label Sep 11, 2018
@karmatosed
Copy link
Member

I would 👍 the ides of resizing and also minimising by default.

@karmatosed karmatosed removed the Needs Design Feedback Needs general design feedback. label Oct 8, 2018
@mtias mtias added the Needs Design Needs design efforts. label Oct 8, 2018
@chrisvanpatten
Copy link
Contributor

I'm happy to take a crack at this with the new ResizableBox component once #10396 lands.

@karmatosed
Copy link
Member

Thanks @chrisvanpatten!

@karmatosed karmatosed added this to the WordPress 5.0.1 milestone Nov 22, 2018
@mtias mtias modified the milestones: WordPress 5.0.1, Future: 5.1 Nov 30, 2018
@nicolad nicolad mentioned this issue Mar 31, 2019
Closed
5 tasks
@gziolo gziolo added the [Status] In Progress Tracking issues with work in progress label Apr 10, 2019
@karmatosed karmatosed added Needs Design Feedback Needs general design feedback. and removed Needs Design Needs design efforts. labels May 2, 2019
@mapk mapk added [Block] HTML Affects the the HTML Block and removed Good First Issue An issue that's suitable for someone looking to contribute for the first time Needs Design Feedback Needs general design feedback. [Feature] Blocks Overall functionality of blocks labels Jun 4, 2019
@nicolad nicolad mentioned this issue Jun 15, 2019
Merged
5 tasks
@noisysocks
Copy link
Member

This issue is a little out of date as we removed CodeMirror from the HTML block in #10396.

#16187 adds a maximum height to the HTML block which fixes the poor UX of having every single line in the HTML block shown at all times.

I'll leave this as closed. We can look into further improvements to the HTML block when if we ever re-add syntax highlighting (see #10423).

@cngodles cngodles mentioned this issue Mar 19, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nicolad nicolad

Labels
[Block] HTML Affects the the HTML Block [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
WordPress 5.x
Development

Successfully merging a pull request may close this issue.

Resizable HTML block. WordPress/gutenberg
WIP: Resizable HTML block.
9 participants
@karmatosed @mtias @noisysocks @mapk @gziolo @designsimply @chrisvanpatten @nicolad @Pikamander2