Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resizable HTML block. #16187

Merged
merged 1 commit into from
Jul 10, 2019
Merged

Resizable HTML block. #16187

merged 1 commit into from
Jul 10, 2019

Conversation

nicolad
Copy link
Member

@nicolad nicolad commented Jun 15, 2019

Description

Fixes: #8245

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.

@nicolad nicolad added [Type] Enhancement A suggestion for improvement. [Block] HTML Affects the the HTML Block labels Jun 15, 2019
@nicolad
Copy link
Member Author

nicolad commented Jun 15, 2019

Had applied fix suggested by @mapk.
The usage of ResizableBox, as previously suggested, seems to be outside of the scope of the initial issue.

@nicolad
Copy link
Member Author

nicolad commented Jun 15, 2019

Here is testing:
Peek 2019-06-15 17-51

@mapk
Copy link
Contributor

mapk commented Jun 25, 2019

Tested and it worked great! :shipit: :shipit:

@noisysocks noisysocks self-requested a review July 10, 2019 04:26
@noisysocks noisysocks merged commit 9f1657d into master Jul 10, 2019
@noisysocks noisysocks deleted the update/html-block-textarea branch July 10, 2019 06:20
@noisysocks noisysocks mentioned this pull request Jul 10, 2019
Closed
@youknowriad youknowriad added this to the Gutenberg 6.2 milestone Jul 26, 2019
@nicolad nicolad self-assigned this Sep 29, 2019
@aurelienpierre aurelienpierre mentioned this pull request Mar 13, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noisysocks noisysocks noisysocks approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra

@gziolo gziolo Awaiting requested review from gziolo

@jorgefilipecosta jorgefilipecosta Awaiting requested review from jorgefilipecosta

@notnownikki notnownikki Awaiting requested review from notnownikki

@Soean Soean Awaiting requested review from Soean

@talldan talldan Awaiting requested review from talldan

@youknowriad youknowriad Awaiting requested review from youknowriad

Assignees

@nicolad nicolad

Labels
[Block] HTML Affects the the HTML Block [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
Gutenberg 6.2
Development

Successfully merging this pull request may close these issues.

Make custom HTML blocks resizable
4 participants
@nicolad @mapk @noisysocks @youknowriad