Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Resizable HTML block. #14730

Closed
wants to merge 134 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
134 commits
Select commit Hold shift + click to select a range
ff5065f
Wrapped HTMLedit with ResizableBox.
nicolad Mar 31, 2019
22656b0
Merge branch 'master' into update/resizable-html-block
nicolad May 30, 2019
055a960
Merge branch 'master' of github.com:WordPress/gutenberg into update/r…
nicolad May 30, 2019
3ef563e
[Mobile] Fix caret position after inline paste - after selection refa…
mkevins May 30, 2019
9420284
Add end 2 end test heading color (#15784)
jorgefilipecosta May 30, 2019
6e2c30b
[RNMobile] Focus RichText on mount if block is selected and says so (…
hypest May 30, 2019
19f9610
Update link on the Gutenberg build files notice (#15697)
arunsathiya May 30, 2019
d47334f
Remove background color text from heading; Fix end to end tests; (#15…
jorgefilipecosta May 30, 2019
2c29b19
Fix menu item colors (#15531)
May 30, 2019
81dcc8d
Update extending-the-block-editor.md (#14841)
yodiyo May 30, 2019
5cfd596
Move misplaced style imports to editor.css (#14607)
m-e-h May 30, 2019
cb8e5d9
Correct default appender insertter jumpiness in Safari (#15892)
kjellr May 30, 2019
d52664c
Build Tooling: Optimize build by spawning worker pool (#15230)
aduth May 30, 2019
5805111
Only apply appender margins when the appender is inside of a block (#…
kjellr May 30, 2019
2acb7d5
Framework: Remove packages build from build, dev scripts (#15226)
aduth May 30, 2019
500a17d
Build: Rebuild package stylesheet entrypoints for file updates (#15920)
aduth May 31, 2019
dfa137f
Update writing-your-first-block-type.md (#15717)
truongwp May 31, 2019
37b3517
Stack consecutive buttons in the featured image area at all times. (#…
kjellr May 31, 2019
5dda5fa
Allow core widgets to be used in the legacy widgets block (#15396)
jorgefilipecosta May 31, 2019
476d8a9
Remove stray flexbox CSS that's no longer needed; closes #11566. (#15…
sarahmonster May 31, 2019
afd56c8
Add overlayColor class name to cover blocks editor markup (#15897) (#…
oxyc May 31, 2019
b78c682
#15941 <br> tag showing issue solved. (#15942)
parmarhardip May 31, 2019
ee8f150
Bail early in createUpgradedEmbedBlock for invalid block types (#15885)
swissspidy May 31, 2019
cc5ba86
Project Management: Merge lib and REST controllers CODEOWNERS (#15925)
aduth May 31, 2019
be4e6f1
Data: Documentation: Document undocumented declarations (#15176)
aduth May 31, 2019
ff7555c
Build: Improve setup of package.json files (#15879)
gziolo Jun 3, 2019
608db0e
UI Components: Refactor BlockSettingsMenu and MoreMenu as DropdownMen…
aduth Jun 3, 2019
b1e848e
Port KeyboardAvoidingView, KeyboardAwareFlatList and ReadableContentV…
Tug Jun 3, 2019
6d91c5f
Remove the use of popular plugins in e2e tests (#15940)
youknowriad Jun 3, 2019
c0608d8
Fix: DateTimePicker styles don't load as expected outside WordPress c…
jorgefilipecosta Jun 3, 2019
6041930
@wordpress/data: Introduce new custom `useDispatch` react hook (#15896)
nerrad Jun 3, 2019
56d9245
Extract generic WordPress mediaUtils package. (#15521)
jorgefilipecosta Jun 3, 2019
c338635
Make sure onEnter is called on the right prop. (#15944)
SergioEstevao Jun 3, 2019
fb16686
Modify reduce-motion mixin so that it works for transitions too. (#1…
kjellr Jun 3, 2019
003e504
Framework: Update link to Docker Desktop (#15950)
aduth Jun 3, 2019
d21bbb0
Add media query hooks and animation to snackbar notices (#15908)
youknowriad Jun 3, 2019
e86f577
Revert inadvertently commented snackbar timeout
youknowriad Jun 3, 2019
5b45ecb
Adds check for attributes in block settings (#15959)
tellthemachines Jun 4, 2019
40fa848
Fix spacer deselection after dragging (#15884)
talldan Jun 4, 2019
4e1e88d
[RNMobile] Moving native tests to gutenberg repo (#15589)
etoledom Jun 4, 2019
9c96bfe
Fix inline docs and add tests for color utils (#15861)
swissspidy Jun 4, 2019
60fb9f3
Redesign Table Block Placeholder (#15903)
tellthemachines Jun 4, 2019
b2c768f
Fixes #15870. Removes the from the editor.scss file allowing it to b…
mapk Jun 4, 2019
c2578bd
Scripts: Ignore linting files located in build folders by default (#1…
gziolo Jun 5, 2019
af5fd92
adds selection persistence on sidebar tab switch (#15583)
draganescu Jun 5, 2019
ba6a8af
Enables Block Grouping/UnGrouping using core/group (#14908)
getdave Jun 5, 2019
3817f47
Scripts: Add default file patterns for linting scripts (#15890)
gziolo Jun 5, 2019
350984d
Style quotes in the mobile app (#15990)
SergioEstevao Jun 5, 2019
e77879b
Refactor remove line separator to method in the rich-text package. (#…
SergioEstevao Jun 5, 2019
6e9e1f7
Extract ServerSideRender component to an independent package (#15635)
jorgefilipecosta Jun 5, 2019
79ba27d
Video block has black background when upload is in progress or upload…
marecar3 Jun 5, 2019
7a28286
Allow passing style to `Icon` for mobile (#15778)
pinarol Jun 5, 2019
6527b23
add important clarification doc removed in #15896 (#15987)
nerrad Jun 5, 2019
000b29b
Prevent rendering of settings button until it has an action (#16000)
pinarol Jun 5, 2019
b0755c0
[Mobile]Enable sound on video block (#15997)
pinarol Jun 6, 2019
f58da98
Update package-lock.json wiht missing entry for server-side-render
gziolo Jun 6, 2019
07ed4b8
Start playback immediately after we go full screen (#15998)
pinarol Jun 6, 2019
0ccabea
Fix: When adding a button block, Button receives focus first #15859 (…
senadir Jun 6, 2019
768a13a
Fix mobile quotes insertion and removal of empty lines (#16013)
SergioEstevao Jun 6, 2019
992ea0a
Always show side inserter on the last empty paragraph (#15864)
youknowriad Jun 6, 2019
f4ad608
Selecting Parent Blocks: Try clickthrough (#15537)
jasmussen Jun 6, 2019
ccc65f8
[Mobile] Move unselected block accessibility handling to block-holder…
Tug Jun 6, 2019
e019b55
[Mobile] Modified More block to be read-only (#16005)
etoledom Jun 6, 2019
9343c0c
Remove a call to a removed function. (#16018)
etoledom Jun 6, 2019
010a6be
Refactor the hovered area component to a hook (#15038)
youknowriad Jun 6, 2019
de965f9
Framework: Introduce "Milestone It" GitHub action (#15826)
aduth Jun 6, 2019
73a3051
Add workflow "Milestone merged pull requests"
aduth Jun 6, 2019
7037708
Format Library: Remove secondary (access) shortcuts (#15191)
ellatrix Jun 7, 2019
32bff1a
Adds an is-busy state to the save button of the widgets page (#16019)
youknowriad Jun 7, 2019
0e864ba
[RNMobile] Fix for extra BR tag on Title field on Android (#16021)
daniloercoli Jun 7, 2019
1128afb
[Mobile]Open video/quote/more blocks to public (#16031)
pinarol Jun 7, 2019
66c9b18
Add: Format library to the widget screen. (#15948)
jorgefilipecosta Jun 7, 2019
0ee264f
Fix: DateTimePicker passes current seconds as the selected seconds va…
jorgefilipecosta Jun 7, 2019
a516f50
Add improved "Group" and "Ungroup" icons (#16001)
kjellr Jun 7, 2019
eae298a
Spacer block: Add clear:both; to clear any floats around it (#15874)
mapk Jun 7, 2019
939332c
Fix "Milestone It" workflow container path
aduth Jun 7, 2019
2e7161c
Remove @wordpress/format-library dependency from edit-post (#16034)
jorgefilipecosta Jun 7, 2019
6c67c96
Framework: Update package-lock.json per #16034
aduth Jun 7, 2019
6fad854
Update increase tooltip selector specificity (#16043)
jorgefilipecosta Jun 7, 2019
a4bd1d0
Block API: Downgrade `convert` API to experimental (#16047)
aduth Jun 7, 2019
936e8fa
Revert "adds selection persistence on sidebar tab switch (#15583)" (#…
aduth Jun 7, 2019
4b12721
Add availability checks to widget related code (#15983)
jorgefilipecosta Jun 7, 2019
24daf82
[RNMobile] keyboard focus issues (#15999)
hypest Jun 7, 2019
283ec19
[docs] document missing prop in MenuItem (#16061)
dsifford Jun 10, 2019
a86ca62
[docs] fix incorect prop name in KeyboardShortcuts (#16059)
dsifford Jun 10, 2019
bdf3826
Deprecated the selectors/actions and components that moved to the bl…
youknowriad Jun 10, 2019
6c6e86c
Update browserslist dependency to fix unit tests (#16066)
youknowriad Jun 10, 2019
b62fc87
Bump plugin version to 5.9.0-rc.1
nerrad Jun 10, 2019
df09f3e
Explicitely push to the release branch (#16070)
youknowriad Jun 10, 2019
74e950a
Update for MediaPlaceholder component: don't stack error messages whe…
Jun 10, 2019
0dafd4d
Editor: Create own sub-registry in default EditorProvider use (#15989)
aduth Jun 10, 2019
7529160
Docs: Change register_meta to register_post_meta (#16032)
Soean Jun 10, 2019
3188fe0
[RNMobile] iOS Image block caption multiline fix (#16071)
etoledom Jun 10, 2019
1d560c8
Make sure no div elements get in the content of quotes. (#16072)
SergioEstevao Jun 10, 2019
945de60
Rnmobile/change colors on rich text mobile (#16016)
SergioEstevao Jun 10, 2019
73fd352
Scripts: Fix default use of lint-js file patterns (#16079)
aduth Jun 11, 2019
36f1a5d
fix(components/tab-panel): improve className safety by using classNam…
dsifford Jun 11, 2019
c3e473e
remove defaultProp from required property in components/modal (#16074)
dsifford Jun 11, 2019
bc77745
docs(components/text-control): Fix incorrectly documented "value" pro…
dsifford Jun 11, 2019
a4c97bb
Fix: Remove editor usage from media blocks. (#15548)
jorgefilipecosta Jun 11, 2019
9714aef
Fix: Playground build; Remove @babel/polyfill import from the playgro…
jorgefilipecosta Jun 11, 2019
29e39c7
Project management: Fix milestone version selection when RC is includ…
gziolo Jun 11, 2019
4a4cbdb
Update fill-rule and clip-rule to fillRule and clipRule (#16096)
kjellr Jun 11, 2019
fdbe9df
[docs] fix incorrect prop documentation for components/date-time (#16…
dsifford Jun 11, 2019
e9ff314
Adjust margins on datepicker to balance (#16097)
Jun 11, 2019
d7991f2
Update Tag Cloud copy when no terms are found (#16098)
melchoyce Jun 11, 2019
874fa8b
Update link to permalink documentation. (#16087)
Soean Jun 12, 2019
198bba2
Fix: For passing the PHP Coding Standards (#16107)
Soean Jun 12, 2019
91da669
Fix horizontal scrollbar on full-wide blocks with nesting. (#16085)
Jun 12, 2019
61d4d51
Bump plugin version to 5.9.0
nerrad Jun 12, 2019
f99e42b
[RNMobile] Fix pasting text on Post Title (#16116)
etoledom Jun 12, 2019
590cfb5
chore(release): publish
youknowriad Jun 12, 2019
6436f4c
Updating changelogs for the Gutenberg 5.9 packages release
youknowriad Jun 12, 2019
a13c79d
Update toolbar-text.png (#16102)
Jun 12, 2019
7ad33cb
Add descriptive text and a link to embed documentation in embed block…
melchoyce Jun 12, 2019
1f1dee3
Bring greater consistency to placeholder text for media blocks. (#16135)
kjellr Jun 12, 2019
6c45316
Add mention of on Figma to CONTRIBUTING.md (#16140)
kjellr Jun 13, 2019
66fbbc3
docs(block-editor/components/inspector-controls): fix image path in R…
technote-space Jun 13, 2019
bd4363d
docs(components/with-focus-return): fix typo in README.md (#16143)
dsifford Jun 13, 2019
a58bcdb
docs(components/higher-order/with-spoken-messages): fix issue in exam…
dsifford Jun 13, 2019
7a5fd55
Add native support for Inserter (Ported from gutenberg-mobile) (#16114)
Tug Jun 13, 2019
30e3fae
Scripts: Fix naming conventions for function containing CLI keyword (…
gziolo Jun 14, 2019
0bc7aea
Build Tooling: Use "full" `npm install` for Build Artifacts Travis ta…
aduth Jun 14, 2019
0d24289
Editor: Fix the issue where statics for deprecated components were no…
gziolo Jun 14, 2019
33f6a6d
Bump plugin version to 5.9.1
gziolo Jun 14, 2019
8b391be
Make calendar block resilient against editor module not being present…
jorgefilipecosta Jun 14, 2019
7978022
Block library: Refactor Heading block to use class names for text ali…
gziolo Jun 14, 2019
3dc3ca8
Scripts: Document and simplify changing file entry and output of buil…
gziolo Jun 14, 2019
b308357
[RNMobile] Native mobile release v1.7.0 (#16156)
hypest Jun 14, 2019
2f63a6e
refactor snackbar to follow spec while keeping compatibility with not…
senadir Jun 14, 2019
0a4fbd5
[Mobile]Update video player to open the URL by browser on Android (#1…
pinarol Jun 14, 2019
259bec1
Support forwardRef components in save functions (#16180)
youknowriad Jun 14, 2019
1b8a083
Bump plugin version to 5.9.2
youknowriad Jun 14, 2019
2aef484
Try making the Inserter category icons grayscale. (#16163)
mapk Jun 14, 2019
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
3 changes: 1 addition & 2 deletions .github/CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -82,8 +82,7 @@
/packages/block-editor/src/components/rich-text @youknowriad @aduth @ellatrix @jorgefilipecosta @daniloercoli @sergioestevao

# PHP
/lib @youknowriad @gziolo @aduth
*-controller.php @youknowriad @gziolo @aduth @timothybjacobs
/lib @youknowriad @gziolo @aduth @timothybjacobs

# Native (Unowned)
*.native.js @ghost
Expand Down
18 changes: 18 additions & 0 deletions .github/actions/milestone-it/Dockerfile
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
FROM debian:stable-slim

LABEL "name"="Milestone It"
LABEL "maintainer"="The WordPress Contributors"
LABEL "version"="1.0.0"

LABEL "com.github.actions.name"="Milestone It"
LABEL "com.github.actions.description"="Assigns a pull request to the next milestone"
LABEL "com.github.actions.icon"="flag"
LABEL "com.github.actions.color"="green"

RUN apt-get update && \
apt-get install --no-install-recommends -y jq curl ca-certificates && \
apt-get clean -y

COPY entrypoint.sh /entrypoint.sh

ENTRYPOINT [ "/entrypoint.sh" ]
81 changes: 81 additions & 0 deletions .github/actions/milestone-it/entrypoint.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,81 @@
#!/bin/bash
set -e

# 1. Determine if milestone already exists (don't replace one which has already
# been assigned).

pr=$(jq -r '.number' $GITHUB_EVENT_PATH)

current_milestone=$(
curl \
--silent \
-H "Authorization: token $GITHUB_TOKEN" \
"https://api.github.com/repos/$GITHUB_REPOSITORY/issues/$pr" \
| jq '.milestone'
)

if [ "$current_milestone" != 'null' ]; then
echo 'Milestone already applied. Aborting.'
exit 1;
fi

# 2. Read current version.

version=$(jq -r '.version' package.json)

IFS='.' read -ra parts <<< "$version"
major=${parts[0]}
minor=${parts[1]}

# 3. Determine next milestone.

if [[ $minor == 9* ]]; then
major=$((major+1))
minor="0"
else
minor=$((minor+1))
fi

milestone="Gutenberg $major.$minor"

# 4. Calculate next milestone due date, using a static reference of an earlier
# release (v5.0) as a reference point for the biweekly release schedule.

reference_major=5
reference_minor=0
reference_date=1549238400
num_versions_elapsed=$(((major-reference_major)*10+(minor-reference_minor)))
weeks=$((num_versions_elapsed*2))
due=$(date -u --iso-8601=seconds -d "$(date -d @$(echo $reference_date)) + $(echo $weeks) weeks")

# 5. Create milestone. This may fail for duplicates, which is expected and
# ignored.

curl \
--silent \
-X POST \
-H "Authorization: token $GITHUB_TOKEN" \
-H "Content-Type: application/json" \
-d "{\"title\":\"$milestone\",\"due_on\":\"$due\",\"description\":\"Tasks to be included in the $milestone plugin release.\"}" \
"https://api.github.com/repos/$GITHUB_REPOSITORY/milestones" > /dev/null

# 6. Find milestone number. This could be improved to allow for non-open status
# or paginated results.

number=$(
curl \
--silent \
-H "Authorization: token $GITHUB_TOKEN" \
"https://api.github.com/repos/$GITHUB_REPOSITORY/milestones" \
| jq ".[] | select(.title == \"$milestone\") | .number"
)

# 7. Assign pull request to milestone.

curl \
--silent \
-X POST \
-H "Authorization: token $GITHUB_TOKEN" \
-H "Content-Type: application/json" \
-d "{\"milestone\":$number}" \
"https://api.github.com/repos/$GITHUB_REPOSITORY/issues/$pr" > /dev/null
15 changes: 15 additions & 0 deletions .github/main.workflow
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
workflow "Milestone merged pull requests" {
on = "pull_request"
resolves = ["Milestone It"]
}

action "Filter merged" {
uses = "actions/bin/filter@3c0b4f0e63ea54ea5df2914b4fabf383368cd0da"
args = "merged true"
}

action "Milestone It" {
uses = "./.github/actions/milestone-it"
needs = ["Filter merged"]
secrets = ["GITHUB_TOKEN"]
}
30 changes: 17 additions & 13 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,11 @@ jobs:

- name: Build artifacts
install:
- npm ci
# A "full" install is executed, since `npm ci` does not always exit
# with an error status code if the lock file is inaccurate.
#
# See: https://github.com/WordPress/gutenberg/issues/16157
- npm install
script:
- npm run check-local-changes

Expand Down Expand Up @@ -81,63 +85,63 @@ jobs:
script:
- ./bin/run-wp-unit-tests.sh

- name: E2E tests (Admin with plugins) (1/4)
env: WP_VERSION=latest SCRIPT_DEBUG=false POPULAR_PLUGINS=true PUPPETEER_SKIP_CHROMIUM_DOWNLOAD=
- name: E2E tests (Admin) (1/4)
env: WP_VERSION=latest SCRIPT_DEBUG=false PUPPETEER_SKIP_CHROMIUM_DOWNLOAD=
install:
- ./bin/setup-travis-e2e-tests.sh
script:
- $( npm bin )/wp-scripts test-e2e --config=./packages/e2e-tests/jest.config.js --listTests > ~/.jest-e2e-tests
- $( npm bin )/wp-scripts test-e2e --config=./packages/e2e-tests/jest.config.js --cacheDirectory="$HOME/.jest-cache" --runTestsByPath $( awk 'NR % 4 == 0' < ~/.jest-e2e-tests )

- name: E2E tests (Admin with plugins) (2/4)
env: WP_VERSION=latest SCRIPT_DEBUG=false POPULAR_PLUGINS=true PUPPETEER_SKIP_CHROMIUM_DOWNLOAD=
- name: E2E tests (Admin) (2/4)
env: WP_VERSION=latest SCRIPT_DEBUG=false PUPPETEER_SKIP_CHROMIUM_DOWNLOAD=
install:
- ./bin/setup-travis-e2e-tests.sh
script:
- $( npm bin )/wp-scripts test-e2e --config=./packages/e2e-tests/jest.config.js --listTests > ~/.jest-e2e-tests
- $( npm bin )/wp-scripts test-e2e --config=./packages/e2e-tests/jest.config.js --cacheDirectory="$HOME/.jest-cache" --runTestsByPath $( awk 'NR % 4 == 1' < ~/.jest-e2e-tests )

- name: E2E tests (Admin with plugins) (3/4)
env: WP_VERSION=latest SCRIPT_DEBUG=false POPULAR_PLUGINS=true PUPPETEER_SKIP_CHROMIUM_DOWNLOAD=
- name: E2E tests (Admin) (3/4)
env: WP_VERSION=latest SCRIPT_DEBUG=false PUPPETEER_SKIP_CHROMIUM_DOWNLOAD=
install:
- ./bin/setup-travis-e2e-tests.sh
script:
- $( npm bin )/wp-scripts test-e2e --config=./packages/e2e-tests/jest.config.js --listTests > ~/.jest-e2e-tests
- $( npm bin )/wp-scripts test-e2e --config=./packages/e2e-tests/jest.config.js --cacheDirectory="$HOME/.jest-cache" --runTestsByPath $( awk 'NR % 4 == 2' < ~/.jest-e2e-tests )

- name: E2E tests (Admin with plugins) (4/4)
env: WP_VERSION=latest SCRIPT_DEBUG=false POPULAR_PLUGINS=true PUPPETEER_SKIP_CHROMIUM_DOWNLOAD=
- name: E2E tests (Admin) (4/4)
env: WP_VERSION=latest SCRIPT_DEBUG=false PUPPETEER_SKIP_CHROMIUM_DOWNLOAD=
install:
- ./bin/setup-travis-e2e-tests.sh
script:
- $( npm bin )/wp-scripts test-e2e --config=./packages/e2e-tests/jest.config.js --listTests > ~/.jest-e2e-tests
- $( npm bin )/wp-scripts test-e2e --config=./packages/e2e-tests/jest.config.js --cacheDirectory="$HOME/.jest-cache" --runTestsByPath $( awk 'NR % 4 == 3' < ~/.jest-e2e-tests )

- name: E2E tests (Author without plugins) (1/4)
- name: E2E tests (Author) (1/4)
env: WP_VERSION=latest SCRIPT_DEBUG=false E2E_ROLE=author PUPPETEER_SKIP_CHROMIUM_DOWNLOAD=
install:
- ./bin/setup-travis-e2e-tests.sh
script:
- $( npm bin )/wp-scripts test-e2e --config=./packages/e2e-tests/jest.config.js --listTests > ~/.jest-e2e-tests
- $( npm bin )/wp-scripts test-e2e --config=./packages/e2e-tests/jest.config.js --cacheDirectory="$HOME/.jest-cache" --runTestsByPath $( awk 'NR % 4 == 0' < ~/.jest-e2e-tests )

- name: E2E tests (Author without plugins) (2/4)
- name: E2E tests (Author) (2/4)
env: WP_VERSION=latest SCRIPT_DEBUG=false E2E_ROLE=author PUPPETEER_SKIP_CHROMIUM_DOWNLOAD=
install:
- ./bin/setup-travis-e2e-tests.sh
script:
- $( npm bin )/wp-scripts test-e2e --config=./packages/e2e-tests/jest.config.js --listTests > ~/.jest-e2e-tests
- $( npm bin )/wp-scripts test-e2e --config=./packages/e2e-tests/jest.config.js --cacheDirectory="$HOME/.jest-cache" --runTestsByPath $( awk 'NR % 4 == 1' < ~/.jest-e2e-tests )

- name: E2E tests (Author without plugins) (3/4)
- name: E2E tests (Author) (3/4)
env: WP_VERSION=latest SCRIPT_DEBUG=false E2E_ROLE=author PUPPETEER_SKIP_CHROMIUM_DOWNLOAD=
install:
- ./bin/setup-travis-e2e-tests.sh
script:
- $( npm bin )/wp-scripts test-e2e --config=./packages/e2e-tests/jest.config.js --listTests > ~/.jest-e2e-tests
- $( npm bin )/wp-scripts test-e2e --config=./packages/e2e-tests/jest.config.js --cacheDirectory="$HOME/.jest-cache" --runTestsByPath $( awk 'NR % 4 == 2' < ~/.jest-e2e-tests )

- name: E2E tests (Author without plugins) (4/4)
- name: E2E tests (Author) (4/4)
env: WP_VERSION=latest SCRIPT_DEBUG=false E2E_ROLE=author PUPPETEER_SKIP_CHROMIUM_DOWNLOAD=
install:
- ./bin/setup-travis-e2e-tests.sh
Expand Down
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ Please see the [Developer Contributions section](/docs/contributors/develop.md)

## How Can Designers Contribute?

If you'd like to contribute to the design or front-end, feel free to contribute to tickets labelled [Needs Design](https://github.com/WordPress/gutenberg/issues?q=is%3Aissue+is%3Aopen+label%3A%22Needs+Design%22) or [Needs Design Feedback](https://github.com/WordPress/gutenberg/issues?q=is%3Aissue+is%3Aopen+label%3A"Needs+Design+Feedback%22). We could use your thoughtful replies, mockups, animatics, sketches, doodles. Proposed changes are best done as minimal and specific iterations on the work that precedes it so we can compare. If you use <a href="https://www.sketchapp.com/">Sketch</a>, you can grab <a href="https://cloudup.com/cMPXM8Va2cy">the source file for the mockups</a> (updated April 6th).
If you'd like to contribute to the design or front-end, feel free to contribute to tickets labelled [Needs Design](https://github.com/WordPress/gutenberg/issues?q=is%3Aissue+is%3Aopen+label%3A%22Needs+Design%22) or [Needs Design Feedback](https://github.com/WordPress/gutenberg/issues?q=is%3Aissue+is%3Aopen+label%3A"Needs+Design+Feedback%22). We could use your thoughtful replies, mockups, animatics, sketches, doodles. Proposed changes are best done as minimal and specific iterations on the work that precedes it so we can compare. The [WordPress Design team](http://make.wordpress.org/design/) uses [Figma](https://www.figma.com/) to collaborate and share work. If you'd like to contribute, join the [#design channel](http://wordpress.slack.com/messages/design/) in [Slack](https://make.wordpress.org/chat/) and ask the team to set you up with a free Figma account. This will give you access to a helpful [library of components](https://www.figma.com/file/ZtN5xslEVYgzU7Dd5CxgGZwq/WordPress-Components?node-id=0%3A1) used in WordPress.

## Contribute to the Documentation

Expand Down
2 changes: 1 addition & 1 deletion assets/stylesheets/_animations.scss
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,5 @@
@mixin edit-post__fade-in-animation($speed: 0.2s, $delay: 0s) {
animation: edit-post__fade-in-animation $speed ease-out $delay;
animation-fill-mode: forwards;
@include reduce-motion;
@include reduce-motion("animation");
}
24 changes: 21 additions & 3 deletions assets/stylesheets/_mixins.scss
Original file line number Diff line number Diff line change
Expand Up @@ -176,6 +176,7 @@
transition: box-shadow 0.1s linear;
border-radius: $radius-round-rectangle;
border: $border-width solid $dark-gray-150;
@include reduce-motion("transition");
}

@mixin input-style__focus() {
Expand Down Expand Up @@ -337,10 +338,27 @@
* Allows users to opt-out of animations via OS-level preferences.
*/

@mixin reduce-motion {
@media (prefers-reduced-motion: reduce) {
animation-duration: 1ms !important;
@mixin reduce-motion($property: "") {

@if $property == "transition" {
@media (prefers-reduced-motion: reduce) {
transition-duration: 0s;
}
}

@else if $property == "animation" {
@media (prefers-reduced-motion: reduce) {
animation-duration: 1ms;
}
}

@else {
@media (prefers-reduced-motion: reduce) {
transition-duration: 0s;
animation-duration: 1ms;
}
}

}

/**
Expand Down
17 changes: 10 additions & 7 deletions assets/stylesheets/_z-index.scss
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ $z-layers: (
".block-library-classic__toolbar": 10,
".block-editor-block-list__layout .reusable-block-indicator": 1,
".block-editor-block-list__breadcrumb": 2,
".editor-inner-blocks .block-editor-block-list__breadcrumb": 22,
".components-form-toggle__input": 1,
".components-panel__header.edit-post-sidebar__panel-tabs": -1,
".edit-post-sidebar .components-panel": -2,
Expand All @@ -19,7 +18,6 @@ $z-layers: (
".components-modal__header": 10,
".edit-post-meta-boxes-area.is-loading::before": 1,
".edit-post-meta-boxes-area .spinner": 5,
".block-editor-block-contextual-toolbar": 21,
".components-popover__close": 5,
".block-editor-block-list__insertion-point": 6,
".block-editor-inserter-with-shortcuts": 5,
Expand Down Expand Up @@ -51,16 +49,21 @@ $z-layers: (
".components-drop-zone": 100,
".components-drop-zone__content": 110,

// The block mover, particularly in nested contexts,
// should overlap most block content.
".block-editor-block-list__block.is-{selected,hovered} .block-editor-block-mover": 80,

// The block mover for floats should overlap the controls of adjacent blocks.
".block-editor-block-list__block {core/image aligned left or right}": 81,

// Small screen inner blocks overlay must be displayed above drop zone,
// settings menu, and movers.
".block-editor-inner-blocks__small-screen-overlay:after": 120,
".block-editor-inner-blocks.has-overlay::after": 120,

// The toolbar, when contextual, should be above any adjacent nested block click overlays.
".block-editor-block-list__layout .reusable-block-edit-panel": 121,
".block-editor-block-contextual-toolbar": 121,
".editor-inner-blocks .block-editor-block-list__breadcrumb": 122,

// The block mover, particularly in nested contexts,
// should overlap most block content.
".block-editor-block-list__block.is-{selected,hovered} .block-editor-block-mover": 121,

// Show sidebar above wp-admin navigation bar for mobile viewports:
// #wpadminbar { z-index: 99999 }
Expand Down
13 changes: 8 additions & 5 deletions bin/commander.js
Original file line number Diff line number Diff line change
Expand Up @@ -278,6 +278,7 @@ async function runReleaseBranchCreationStep( abortMessage ) {
return {
version,
versionLabel,
releaseBranch,
};
}

Expand Down Expand Up @@ -320,6 +321,7 @@ async function runReleaseBranchCheckoutStep( abortMessage ) {
return {
version,
versionLabel: version,
releaseBranch,
};
}

Expand Down Expand Up @@ -415,17 +417,18 @@ async function runCreateGitTagStep( version, abortMessage ) {
/**
* Push the local Git Changes and Tags to the remote repository.
*
* @param {string} abortMessage Abort message.
* @param {string} releaseBranch Release branch name.
* @param {string} abortMessage Abort message.
*/
async function runPushGitChangesStep( abortMessage ) {
async function runPushGitChangesStep( releaseBranch, abortMessage ) {
await runStep( 'Pushing the release branch and the tag', abortMessage, async () => {
const simpleGit = SimpleGit( gitWorkingDirectoryPath );
await askForConfirmationToContinue(
'The release branch and the tag are going to be pushed to the remote repository. Continue?',
true,
abortMessage
);
await simpleGit.push( 'origin' );
await simpleGit.push( 'origin', releaseBranch );
await simpleGit.pushTags( 'origin' );
} );
}
Expand Down Expand Up @@ -539,7 +542,7 @@ async function releasePlugin( isRC = true ) {
await runGitRepositoryCloneStep( abortMessage );

// Creating the release branch
const { version, versionLabel } = isRC ?
const { version, versionLabel, releaseBranch } = isRC ?
await runReleaseBranchCreationStep( abortMessage ) :
await runReleaseBranchCheckoutStep( abortMessage );

Expand All @@ -553,7 +556,7 @@ async function releasePlugin( isRC = true ) {
await runCreateGitTagStep( version, abortMessage );

// Push the local changes
await runPushGitChangesStep( abortMessage );
await runPushGitChangesStep( releaseBranch, abortMessage );
abortMessage = 'Aborting! Make sure to ' + isRC ? 'remove' : 'reset' + ' the remote release branch and remove the git tag.';

// Creating the GitHub Release
Expand Down
2 changes: 1 addition & 1 deletion bin/install-docker.sh
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ set -e

# Check that Docker is installed.
if ! command_exists "docker"; then
echo -e $(error_message "Docker doesn't seem to be installed. Please head on over to the Docker site to download it: $(action_format "https://www.docker.com/community-edition#/download")")
echo -e $(error_message "Docker doesn't seem to be installed. Please head on over to the Docker site to download it: $(action_format "https://www.docker.com/products/docker-desktop")")
exit 1
fi

Expand Down
5 changes: 0 additions & 5 deletions bin/install-wordpress.sh
Original file line number Diff line number Diff line change
Expand Up @@ -90,11 +90,6 @@ fi
echo -e $(status_message "Activating Gutenberg...")
docker-compose $DOCKER_COMPOSE_FILE_OPTIONS run --rm -u 33 $CLI plugin activate gutenberg --quiet

if [ "$POPULAR_PLUGINS" == "true" ]; then
echo -e $(status_message "Activating popular plugins...")
docker-compose $DOCKER_COMPOSE_FILE_OPTIONS run --rm -u 33 $CLI plugin install advanced-custom-fields jetpack wpforms-lite --activate --quiet
fi

# Install a dummy favicon to avoid 404 errors.
echo -e $(status_message "Installing a dummy favicon...")
docker-compose $DOCKER_COMPOSE_FILE_OPTIONS run --rm $CONTAINER touch /var/www/html/favicon.ico
Expand Down
Loading