Fix responsive issues & a dimming issue #1691
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue with the dimming layer on the cover image, and then it does a fair bit of rewriting of the sidebar code to make it work better on mobile.
It's still a bit of a work in progress, but I'm assigning reviewers early because the CSS is sort of gnarly and I'd appreciate insights.
Also — while working on this, I discovered that WordPress has already solved CSS bleed with a class called
modal-open
. It's pretty magical, and I would love it if we can apply this to the sidebar when on mobile. See more info here: #656 (comment) — but this should probably be done in a separate PR.Steps to test: