Use the default post comments template for the post comments listing #21012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Type] Enhancement
youknowriad
requested review from
ajitbohra,
jorgefilipecosta,
Soean and
talldan
as code owners
53 tasks
|
Size Change: 0 B Total Size: 856 kB ℹ️ View Unchanged
|
|
Can I get some reviews here @noahtallen @vindl @johnstonphilip |
|
Eventually it'd follow the same path as the post templates, yes, but agreed it's a bit too soon and I'd like to see the post ones in a place we are fully comfortable with before expanding. |
vindl
reviewed
Mar 24, 2020
| ob_get_clean(); | ||
|
|
||
| ob_start(); | ||
| wp_list_comments(array( |
There was a problem hiding this comment.
I don't think we need to call wp_list_comments explicitly here since it's already called in comments.php. If I'm not missing something, it seems that this can be simplified to:
ob_start();
comments_template();
return ob_get_clean();We can optionally call it with dummy_path or similar if we want to force the usage of theme-compat template.
There was a problem hiding this comment.
We can't do that since this function generates the deprecated message.
Also, it seems that this function doesn't output the HTML consistently.
Will not display the comments template if not on single post or page, or if the post does not have comments.
https://developer.wordpress.org/reference/functions/comments_template/
youknowriad
force-pushed
the
update/post-comments-template
branch
3 times, most recently
from
688a996 to
7306d1c
Compare
vindl
approved these changes
Mar 27, 2020
youknowriad
force-pushed
the
update/post-comments-template
branch
from
7306d1c to
8686244
Compare
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #20791
The Post comments block was using an adhoc template for the comments list. This PR updates the block to rely on the default one that ships with WordPress.
Apparently, this template is deprecated though but it's handy for the FSE block so we might consider removing the deprecation.
Notes
While working on this, I actually wondered whether we'd need to build comments blocks suite (comment author block, comment content, comment avatar...) and use them in a comment query block (similar to what we're doing with the post blocks.
My thinking is that it's too soon for these, and the use-cases are smaller than the post ones. cc @mtias