Refactored BlockSwitcher to functional components using hooks #24431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
August 6, 2020 21:36
…lkaruzi/gutenberg into refactor/block-switcher-component
Refactored BlockSwitcher to functional components using hooks
…lkaruzi/gutenberg into refactor/block-switcher-component
…lkaruzi/gutenberg into refactor/block-switcher-component
ZebulanStanphill
added
[Package] Block editor
|
Hi @javidalkaruzi, thanks for your PR! Unfortunately, this one has fallen through the cracks and I see that, in the meantime, the same refactoring has already been done through another PR: #27674. Duplicating efforts is something we strive to avoid but is bound to happen in a project of this scale. I'm going to close this PR, but I hope to see more of your contributions to Gutenberg! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related to #22890.
Refactored BlockSwitcher to use React Hooks.
How has this been tested?
Tested using existing unit tests for BlockSwitcher.
Tested by running
npm run test.Observed that I was able to switch blocks using Gutenberg block editor.
Checklist: