Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include Legacy Widget block files in the plugin build #32803

Merged
merged 1 commit into from
Jun 18, 2021

Conversation

Mamaduka
Copy link
Member

Description

Updates plugin ZIP creation to include the Legacy Widget block files.

Fixes #32785.
Fixes #32795.

How has this been tested?

  1. Run bin/build-plugin-zip.sh in plugin directory.
  2. Make sure the widgets package has a block directory with structure:
blocks/
  legecy-widget/block.json
  legacy-widget.php

Types of changes

Bugfix

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).

@Mamaduka Mamaduka self-assigned this Jun 18, 2021
@Mamaduka Mamaduka added [Block] Legacy Widget Affects the Legacy Widget Block - used for displaying Classic Widgets [Package] Project management automation /packages/project-management-automation [Type] Bug An existing feature does not function as intended labels Jun 18, 2021
@Mamaduka Mamaduka requested a review from noisysocks June 18, 2021 05:15
@gziolo gziolo requested review from talldan and draganescu June 18, 2021 09:05
Copy link
Contributor

@ockham ockham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this with a fresh WP install. I installed GB 10.9 RC1 and verified that the error messages seen in the issues linked in the PR desc were present.

I then removed it and installed the plugin build from this PR instead. This time, I didn't get the same error messages 👍

Also noting that the issue isn't present in 10.8.2, so we don't have to backport to the 10.8 branch.

@Mamaduka
Copy link
Member Author

Thanks for testing, @ockham.

@Mamaduka Mamaduka merged commit dbaa748 into trunk Jun 18, 2021
@Mamaduka Mamaduka deleted the fix/include-legacy-widget-build branch June 18, 2021 15:58
@ockham
Copy link
Contributor

ockham commented Jun 18, 2021

Cherry-picked to release/10.9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Legacy Widget Affects the Legacy Widget Block - used for displaying Classic Widgets [Package] Project management automation /packages/project-management-automation [Type] Bug An existing feature does not function as intended
Projects
None yet
3 participants