[Experiment] Capture screencasts for failing tests #33506
Closed
+309
−122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin940726
added
[Type] Enhancement
|
Size Change: -90 B (0%) Total Size: 1.07 MB
ℹ️ View Unchanged
|
kevin940726
force-pushed
the
add/failure-screencast
branch
from
eab1f5b to
e2af388
Compare
|
💯 thank you for exploring that @kevin940726 ! I wonder if it would be simpler to leverage this API instead: let displayMediaOptions = {video: true, audio: false};
navigator.mediaDevices.getDisplayMedia(displayMediaOptions)
.then(function(stream){
video_el.srcObject = stream;
})Normally you have to click on a dialog window to confirm which window you want to capture, but I wonder if there's a way around that in puppeteer. This could potentially help: puppeteer/puppeteer#4835 |
|
I can see the video in the artifacts bundle, great job! One thing that's inconsistent is how short the video is (3s) |
|
Any details about this change? What was wrong previously? |
|
@youknowriad it's a new thing. We have a screenshot capture now, this adds a video capture. |
kevin940726
force-pushed
the
add/failure-screencast
branch
from
bd94797 to
ad48e50
Compare
|
That's a nice feature 👍🏻 I'm wondering how much does it impact the duration of individual tests when the screencast is recorded. For the screenshot you only take an action when the test fails, here you probably need to record every test and store it only when the test fails. |
kevin940726
force-pushed
the
add/failure-screencast
branch
2 times, most recently
from
96e2ccd to
18624e7
Compare
kevin940726
force-pushed
the
add/failure-screencast
branch
2 times, most recently
from
123cb26 to
d625f16
Compare
kevin940726
force-pushed
the
add/failure-screencast
branch
from
0e8e1f2 to
085c4bf
Compare
10 tasks
|
Superseded by #38570. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Capture screencasts for failing tests.
How has this been tested?
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).