Try: Title block gap. #34570
Merged
Try: Title block gap. #34570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +28 B (0%) Total Size: 1.04 MB
ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When a theme uses block gap to space out blocks, there isn't meant to be a top-margin on the first block in post contents (except for a small bug, #34441).
Currently the post title has an explicit bottom margin of zero. This is set because it assumes blocks that have both top and bottom margins that rely on margin collapsing. But the title block is separate and margins don't collapse into it. In this layout, the zero margin on the title works to rely on the first block of the post content to have margins.
So in themes that use block gap to space blocks out, the zero top margin means there's no space between title and content:
This PR changes that by leveraging the block gap CSS variable to set a bottom margin on the title block. It has zero as a fallback, for themes that do not use block gap:
How has this been tested?
Checklist:
*.native.jsfiles for terms that need renaming or removal).