Inserter: Target end-of-content styles to specific inserter #3597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduth
added
the
[Feature] Inserter
aduth
force-pushed
the
fix/between-inserter-styling
branch
from
66f630c to
7f925b7
Compare
Codecov Report
@@ Coverage Diff @@
## master #3597 +/- ##
==========================================
- Coverage 36.56% 36.41% -0.16%
==========================================
Files 267 267
Lines 6632 6660 +28
Branches 1203 1210 +7
==========================================
Hits 2425 2425
- Misses 3554 3575 +21
- Partials 653 660 +7
Continue to review full report at Codecov.
|
|
Sorry I missed the review ping. But nice work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regression introduced in #3546
This pull request seeks to resolve a styling issue with the between-inserter where it appears positioned lower than it should be. This was an unanticipated side effect of moving styles in #3546 where two styles of equal specificity were reordered. The proposed changes here eliminate one of these two styles, moving instead the intended styling to target the end-of-content inserter more specifically, instead of applying styles to all inserters within the visual editor.
Testing instructions:
Verify that the between-inserter is positioned vertically as expected (at the mid point on the top and bottom lines of a selected block).
Verify that the end-of-content inserter is positioned as expected (aligned horizontally to left of block content), in small and large viewports.