Try additional CSS selectors for Button block styles #36130
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jffng
added
[Block] Buttons
jffng
requested review from
scruffian,
colorful-tones,
oandregal,
kjellr and
MaggieCabrera
jffng
commented
Nov 1, 2021
| @@ -77,7 +77,8 @@ | |||
| "radius": true, | |||
| "__experimentalSkipSerialization": true | |||
| }, | |||
| "__experimentalSelector": ".wp-block-button__link" | |||
| "__experimentalSelector": ".wp-block-button__link", | |||
There was a problem hiding this comment.
We could also just change this to include the additional selectors...
|
Size Change: +189 B (0%) Total Size: 1.08 MB
ℹ️ View Unchanged
|
jffng
changed the title
|
Hey, this is an issue and there are some alternatives:
I'd think this PR is too risky to add for 5.9. It raises the question as to why a given block (button) should control other block's styles (search & files): this breaks the block contract (each one is isolated from the others). If we still wanted to go with this, at the practical level, we'd need to test this works well as we may run into multiple specificity clashes. One potential way forward would be to move this to the theme territory until core has a solution. I'd do something similar to what I suggested here #34141 (comment) TLDR: generate css custom properties that track the button styles to reuse in whatever other blocks the theme wants. |
Tried that here, it works but this feedback is still relevant, just defers it to the theme:
Closing this PR for now until we more clarity around how styling these elements should be handled. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In Twenty Twenty-Two, we want to style the buttons in the Search block and File block, and we want them to be consistent with the button block styling. This might ideally be done via theme.json in the future, but needs more consideration (see #29167).
We don't want to write CSS to target these buttons because those styles would not be configurable via global styles. So I had a different idea — output additional selectors to the same CSS declaration generated from theme.json's
styles.blocks.core/button, to target the buttons inside the Search and File block.This PR does two main things:
Questions
How has this been tested?
Screenshots
Types of changes
New feature
Checklist:
*.native.jsfiles for terms that need renaming or removal).