Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blocks: Add view script to block schema and docs #36175

Merged
merged 1 commit into from
Nov 3, 2021
Merged

Blocks: Add view script to block schema and docs #36175

merged 1 commit into from
Nov 3, 2021

Conversation

gziolo
Copy link
Member

@gziolo gziolo commented Nov 3, 2021 •
edited
Loading

Description

Part of #35902.

It adds the missing viewScript fields to block.json related documentation and schema. It's going to be part of WordPress core starting from 5.9 release.

Types of changes

Documentation.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).

@gziolo gziolo added [Feature] Block API API that allows to express the block paradigm. [Type] Developer Documentation Documentation for developers labels Nov 3, 2021
@gziolo gziolo requested review from mkaz and aristath November 3, 2021 13:11
@gziolo gziolo self-assigned this Nov 3, 2021
@gziolo gziolo requested a review from ajitbohra as a code owner November 3, 2021 13:11
@gziolo gziolo mentioned this pull request Nov 3, 2021
Closed
8 tasks
aristath
aristath approved these changes Nov 3, 2021
View reviewed changes
Copy link
Member

@aristath aristath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@gziolo gziolo merged commit aa86e96 into trunk Nov 3, 2021
@gziolo gziolo deleted the update/block-api-schema branch November 3, 2021 15:21
@github-actions github-actions bot added this to the Gutenberg 11.9 milestone Nov 3, 2021
This was referenced Nov 4, 2021
Closed
Merged
madskristensen pushed a commit to SchemaStore/schemastore that referenced this pull request Nov 4, 2021
@gziolo
Add viewScript field to block.json schema (#1915)
6c35228 
* Add `viewScript` field to `block.json` schema

Related changes in the Gutenberg project for the `block.json` scheme and documentation in WordPress/gutenberg#36175.

* Fix whitespaces
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aristath aristath aristath approved these changes

@mkaz mkaz Awaiting requested review from mkaz

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

Assignees

@gziolo gziolo

Labels
[Feature] Block API API that allows to express the block paradigm. [Type] Developer Documentation Documentation for developers
Projects
None yet
Milestone
Gutenberg 11.9
Development

Successfully merging this pull request may close these issues.
2 participants
@gziolo @aristath