Navigation: Remove outdated separate "Home" link styles #36608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmussen
added
[Type] Code Quality
|
Size Change: -634 B (0%) Total Size: 1.1 MB
ℹ️ View Unchanged
|
|
I was able to confirm the issue, and the pull request solves it. This block is not already in WordPress core (unless you can show me where, because I do not see it in trunk?), |
carolinan
approved these changes
Nov 19, 2021
|
Thank you for the review. I think it's entirely harmless to not backport this one, it's mostly a cleanup. The styles output were overridden by the generic classes anyway. But the block should be shipped already. The way you insert it is a bit roundabout at the moment: This speaks to us needing to continue to refine and improve the "lighter navigation flow" (#34041), which right now leans heavily towards the simpler experience. |
|
Yeah I struggled with figuring out how to add the block. |
|
It is not included: https://core.trac.wordpress.org/browser/trunk/src/wp-includes/blocks?rev=52212 |
jasmussen
removed
the
Backport to WP 6.7 Beta/RC
|
Ah! No urgency then. Thanks again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The Home link block which can be inserted in the Navigation block simply links to your homepage. It currently duplicates some styles (padding, margin, others) from other Navigation items. But as of #33918, those styles are no longer needed. This PR removes them.
How has this been tested?
Try the navigation block with a home link, and verify that the Home link has the same paddings, gap and other metrics that other items have:
Checklist:
*.native.jsfiles for terms that need renaming or removal).