Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove core/post-comments-form block styles that are overriding button element styles #42053

Merged
merged 13 commits into from
Jul 15, 2022
Merged

Remove core/post-comments-form block styles that are overriding button element styles #42053

Show file tree
Hide file tree
Changes from 11 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
3a73d5f
Post comments form: removing styles targeting submit button because t…
matiasbenedetto Jun 29, 2022
c5429d9
Removing just the properties provided by theme.json
matiasbenedetto Jun 29, 2022
e3efdeb
Elements: Buttons: Style the cursor for all button elements
scruffian Jul 1, 2022
64b2a8e
move to block library
scruffian Jul 1, 2022
58e05e7
move to style.scss
scruffian Jul 1, 2022
49445d2
Element styles: Load them in the common.scss file instead of the styl…
matiasbenedetto Jul 4, 2022
7d69395
Merge branch 'trunk' into fix/button-cursors-scss-path
matiasbenedetto Jul 4, 2022
138b164
Removing elements.scss from style.scss
matiasbenedetto Jul 4, 2022
a002d3d
Merge branch 'fix/button-cursors-scss-path' into fix/42052
matiasbenedetto Jul 5, 2022
aeef36f
core/post-comments-form: removing unneeded class from submit button t…
matiasbenedetto Jul 5, 2022
7457a0f
default theme.json button element settings: adding border 0.
matiasbenedetto Jul 5, 2022
b6ae58c
Merge branch 'trunk' into fix/42052
matiasbenedetto Jul 11, 2022
4912608
post comments form server side rendering: removing the 'submit' css c…
matiasbenedetto Jul 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions lib/compat/wordpress-6.1/theme.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,6 +262,9 @@
"fontFamily": "inherit",
"lineHeight": "inherit",
"textDecoration": "none"
},
"border": {
"width": "0"
}
},
"link": {
Expand Down
2 changes: 2 additions & 0 deletions packages/block-library/src/common.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
@import "./elements.scss";

// The following selectors have increased specificity (using the :root prefix)
// to assure colors take effect over another base class color, mainly to let
// the colors override the added specificity by link states such as :hover.
Expand Down
1 change: 0 additions & 1 deletion packages/block-library/src/post-comments-form/form.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@ const CommentsForm = () => {
name="submit"
type="submit"
className={ classnames(
'submit',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where else is this class? If it's not needed should we remove the directives as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't found the class anywhere else in Gutenberg codebase.
The CSS directives live in the WordPress core repo: https://github.com/WordPress/wordpress-develop/blob/0a17a80bccd452b91c3b63f71f010ba131a2c954/src/wp-admin/css/forms.css#L415-L421

'wp-block-button__link',
__experimentalGetElementClassName( 'button' )
) }
Expand Down
1 change: 0 additions & 1 deletion packages/block-library/src/post-comments-form/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@

// Styles copied from button block styles.
input[type="submit"] {
border: none;
box-shadow: none;
cursor: pointer;
display: inline-block;
Expand Down
1 change: 0 additions & 1 deletion packages/block-library/src/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,4 +50,3 @@
@import "./video/style.scss";

@import "common.scss";
@import "./elements.scss";