-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Group: Try setting inherit to true if the block is empty and hasn't set an inherit value yet #42876
Closed
andrewserong
wants to merge
1
commit into
trunk
from
try/setting-empty-group-blocks-to-inherit-true-when-empty-and-undefined
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…et an inherit value yet
Size Change: +39 B (0%) Total Size: 1.26 MB
ℹ️ View Unchanged
|
Just closing out this PR as it was more of an experiment / way to try to demonstrate and idea, rather than a PR intended to properly implement the feature. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
🚧 🚧 🚧 🚧 🚧
This is just a hacky WIP exploration based on discussion in #42763 (comment), and exploring ideas that @tellthemachines originally created in #42582.
The idea in this PR is to see if it's possible for us to effectively switch the default for the Group block's
layout.inherit
value without deprecations or affecting blocks that are already out in the wild and containing content.Why?
As raised in both #42763 and #42582, each of the approaches results in challenging edge cases, so this PR is just another exploration into the ideas discussed!
How?
inherit
value to eithertrue
orfalse
. If that's the case, then set it totrue
.Testing Instructions
inherit
being set totrue
(the full width toggle is off by default)Here's some test markup:
Test Group block markup
Screenshots or screencast