Navigation: Page List fix missing padding. #43358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmussen
added
[Type] Bug
jasmussen
force-pushed
the
fix/page-list-padding
branch
from
36691f4 to
40ad071
Compare
|
Size Change: +2 B (0%) Total Size: 1.24 MB
ℹ️ View Unchanged
|
carolinan
approved these changes
Aug 19, 2022
|
🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #43348.
Why?
#42967 caused a small regression by targetting
.wp-block-navigation-linkfor padding, which only exists in custom menu items (it's the old name), where it should have targetted.wp-block-navigation-itemwhich exists for both page list and custom menu items..This PR fixes that.
Testing Instructions
Test nav menus with and without page list, with submenu items, with and without backgrounds, and page list versions should look identical, editor and frontend, to custom items.
Screenshots or screencast
Before:
After: