Search block: fix defaults when inserted into navigation block #52342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jffng
added
the
[Block] Search
|
Size Change: -98 B (0%) Total Size: 1.42 MB
ℹ️ View Unchanged
|
|
Thanks for the PR! I think this side effect was introduced in #36125 to apply a default style (No label, icon button, inside button) when a search block is inserted into a navigation block. Therefore, simply removing this side effect would cause regression regarding #31127, which was resolved in the past. I think the fundamental problem is that when we change the attributes of a search block that has already been inserted, an unintended side effect is executed. I think it would be better to adjust the intended behavior without removing this side effect. This PRpr.mp4Trunktrunk.mp4 |
|
I see what you mean, I will try fixing the intended behavior of this side effect instead of removing it. After more investigation, it looks like |
jffng
changed the title
|
I didn't work out how to solve this yet, but I did find something we can simplify: #52519 |
|
I think we can fix this with #52558 |
|
Closing in favor of #52558. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Attempting to fix #51713.
Why?
See #51713
How?
TBD
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast